Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make loadJS use the same error handling as runJS #199

Merged
merged 2 commits into from Aug 9, 2021
Merged

Make loadJS use the same error handling as runJS #199

merged 2 commits into from Aug 9, 2021

Conversation

calebeby
Copy link
Member

@calebeby calebeby commented Aug 2, 2021 •
edited

Now loadJS will source-map errors the same way runJS does.

Closes #175

@calebeby calebeby marked this pull request as ready for review August 2, 2021 21:50
@calebeby calebeby merged commit 8e26bea into main Aug 9, 2021
@calebeby calebeby deleted the loadjs-error-handling branch August 9, 2021 20:47
@github-actions github-actions bot mentioned this pull request Aug 9, 2021
Merged
@calebeby calebeby mentioned this pull request Aug 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaceninja spaceninja spaceninja approved these changes

@gerardo-rodriguez gerardo-rodriguez Awaiting requested review from gerardo-rodriguez

@Paul-Hebert Paul-Hebert Awaiting requested review from Paul-Hebert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LoadJS is missing the source-map-based-error-generation from runJS
2 participants
@calebeby @spaceninja