Improve html printing #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- HTML syntax highlighting in error messages - Non-significant whitespace in HTML in error messages is collapsed
…pleasantest into improve-html-printing
calebeby
requested review from
spaceninja,
gerardo-rodriguez and
Paul-Hebert
Co-authored-by: Gerardo Rodriguez <gerardo@cloudfour.com>
gerardo-rodriguez
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
This is awesome, @calebeby, so much better! 🎉
I left a couple of small questions/suggestions. I approve pending resolution of those edits.
Let me know if you would like another review, otherwise, LGTM! 👍
Co-authored-by: Gerardo Rodriguez <gerardo@cloudfour.com>
Co-authored-by: Gerardo Rodriguez <gerardo@cloudfour.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #282
Now non-significant whitespace is collapsed when HTML elements are printed in error messages.
And HTML is syntax highlighted in error messages