Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user.type and refactor user API #48

Merged
merged 12 commits into from
Mar 25, 2021
Merged

Add user.type and refactor user API #48

merged 12 commits into from
Mar 25, 2021

Conversation

calebeby
Copy link
Member

No description provided.

@calebeby calebeby marked this pull request as ready for review March 16, 2021 16:58
@calebeby calebeby changed the title [WIP] add user.type Add user.type and refactor user API Mar 16, 2021
@calebeby
Copy link
Member Author

calebeby commented Mar 16, 2021 •
edited
Loading

TODO: add changeset

@calebeby
Copy link
Member Author

calebeby commented Mar 19, 2021 •
edited
Loading

TODO: Change isVisible/isAttached to private/undocumented

@calebeby
Merge remote-tracking branch 'origin/main' into type-method
5067f35
@calebeby
Use toHaveValue
5b6ddc0
@calebeby
Remove/make private user.isAttached and user.isVisible
05af053 
Moved the implementations of those two methods into the actionability
since they will only be used there (at least for now)
@calebeby
Remove a test
04017d2
@calebeby
Add changeset
7885336
@calebeby calebeby merged commit 064e5b4 into main Mar 25, 2021
@calebeby calebeby deleted the type-method branch March 25, 2021 00:38
@github-actions github-actions bot mentioned this pull request Mar 25, 2021
Merged
@calebeby calebeby mentioned this pull request Mar 25, 2021
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonthis emersonthis Awaiting requested review from emersonthis

@gerardo-rodriguez gerardo-rodriguez Awaiting requested review from gerardo-rodriguez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@calebeby