Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update puppeteer #640

Merged
merged 5 commits into from Jan 31, 2023
Merged

Update puppeteer #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3417709
Update puppeteer
calebeby Jan 30, 2023
7d5a17d
@axe-core/puppeteer comes with axe-core, so users don't need to direc…
calebeby Jan 30, 2023
9e2e9b2
One more docs update
calebeby Jan 30, 2023
5b5df6b
Lint disable
calebeby Jan 30, 2023
73ee5e5
Merge remote-tracking branch 'origin/main' into update-puppeteer
calebeby Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tall-brooms-serve.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
'pleasantest': minor
---

Bump puppeteer and @axe-core/puppeteer versions
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Expand Up @@ -669,7 +669,7 @@ test(
);
```

To pass variables from the test environment into the browser, you can pass them in an array as the 2nd parameter. Note that they must either be JSON-serializable or they can be a [`JSHandle`](https://pptr.dev/api/puppeteer.jshandle) or an [`ElementHandle`](https://pptr.dev/#?product=Puppeteer&version=v13.0.0&show=api-class-elementhandle). The arguments will be received in the browser via `import.meta.pleasantestArgs`:
To pass variables from the test environment into the browser, you can pass them in an array as the 2nd parameter. Note that they must either be JSON-serializable or they can be a [`JSHandle`](https://pptr.dev/api/puppeteer.jshandle) or an [`ElementHandle`](https://pptr.dev/api/puppeteer.elementhandle/). The arguments will be received in the browser via `import.meta.pleasantestArgs`:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated but it was a link I missed changing when I went through to switch the links to their new docs site


```js
import { withBrowser } from 'pleasantest';
Expand Down Expand Up @@ -935,7 +935,7 @@ test(

This assertion, based on [`jest-puppeteer-axe`](https://github.com/WordPress/gutenberg/tree/3b2eccc289cfc90bd99252b12fc4c6e470ce4c04/packages/jest-puppeteer-axe), allows you to check a page using the [axe accessibility linter](https://github.com/dequelabs/axe-core).

To use this assertion, you **must install `@axe-core/puppeteer` and `axe-core`**. They are optional peer dependencies for Pleasantest, but are needed for the `toPassAxeTests` assertion.
To use this assertion, you **must install `@axe-core/puppeteer`**. It is listed as an optional peer dependency for Pleasantest, but it is necessary for the `toPassAxeTests` assertion.

```js
test(
Expand Down