Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package-lock.json #9

Closed
calebeby opened this issue Feb 14, 2019 · 2 comments
Closed

Add package-lock.json #9

calebeby opened this issue Feb 14, 2019 · 2 comments

Comments

@calebeby
Copy link
Member

It is currently missing package-lock.json
@spaceninja
Copy link
Member

That's intentional — the recommendation is to not include package.lock for config packages:

Lockfiles for apps, but not for packages

Stylelint debate about this

@spaceninja
Copy link
Member

Upon closer readings of those threads, I found some good counterpoints:

  1. the biggest argument against package-lock was that it requires constantly updating dependencies. Which we get for free from Renovate.

  2. This blog post from the Yarn team about using lockfiles in libraries.

TL;DR: Listen to @calebeby ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spaceninja @calebeby