Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 程序优化 #8

Merged
merged 4 commits into from
Jul 29, 2022
Merged

Conversation

luoqiz
Copy link
Contributor

@luoqiz luoqiz commented Jul 28, 2022

No description provided.

@cloudhao1999 cloudhao1999 merged commit 4e71e33 into cloudhao1999:master Jul 29, 2022
@cloudhao1999
Copy link
Owner

image

这部分的改造其实是有待商榷的,首先params的类型定义中就有param和data的区分

image

在使用说明中也有所提及

image

所以这部分的改造我暂时先还原了,最新的改动可以查看提交记录。不过很感谢你对项目的关注,借此机会我也发现了一些其他问题~

@cloudhao1999
Copy link
Owner

改成data可能会使得使用的场景有进一步减少的可能,例如post方法需要同时支持params和data的情况,当前的实现可以这样

http.request('post', '/xxx', { params: param, data: formData });

image

cloudhao1999 pushed a commit that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants