Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl-to-sample broken on windows #66

Closed
guysv opened this issue Feb 9, 2020 · 5 comments
Closed

ctrl-to-sample broken on windows #66

guysv opened this issue Feb 9, 2020 · 5 comments
Labels
platform:windows type:bug Something isn't working

Comments

@guysv
Copy link

guysv commented Feb 9, 2020

hi, love this software!
the ctrl keyboard shortcut for sampler tool does not seem to respond on windows. The brush tool just keeps being active.
Ill have some time to investigate it myself tomorrow, but for now I post about it here.
tested with:
rx 0.4.0
AND
rx master

rustup show

Default host: x86_64-pc-windows-msvc
rustup home:  C:\Users\User\.rustup

installed toolchains
--------------------

stable-x86_64-pc-windows-msvc
nightly-x86_64-pc-windows-msvc (default)

active toolchain
----------------

nightly-x86_64-pc-windows-msvc (default)
rustc 1.43.0-nightly (442ae7f04 2020-02-06)

cmake (not sure why I list that but why not)

cmake version 3.16.4
@cloudhead
Copy link
Owner

Hey, could you load rx with the -v flag for verbose output, and paste the full output as well as when you press <ctrl>?

Can you also check if other shortcuts work?

Thanks

@cloudhead cloudhead added platform:windows type:bug Something isn't working labels Feb 10, 2020
@guysv
Copy link
Author

guysv commented Feb 11, 2020

2020-02-11 19:35:19,942 DEBUG [rx] event: KeyboardInput(KeyboardInput { state: Pressed, key: Some(Control), modifiers: ModifiersState { shift: false, ctrl: true, alt: false, meta: false } })
2020-02-11 19:35:20,115 DEBUG [rx] event: MouseInput { state: Pressed, button: Left, modifiers: ModifiersState { shift: false, ctrl: true, alt: false, meta: false } }
2020-02-11 19:35:20,204 DEBUG [rx] event: MouseInput { state: Released, button: Left, modifiers: ModifiersState { shift: false, ctrl: true, alt: false, meta: false } }
2020-02-11 19:35:20,426 DEBUG [rx] event: KeyboardInput(KeyboardInput { state: Released, key: Some(Control), modifiers: ModifiersState { shift: false, ctrl: false, alt: false, meta: false } })
2020-02-11 19:35:20,426 DEBUG [rx::session] command: ToolPrev

For what I checked, everything else worked as expected.

@cloudhead
Copy link
Owner

Thanks, I have an idea how to fix this.

@cloudhead
Copy link
Owner

73f26c2 in master should fix it, can you give it a try?

@guysv
Copy link
Author

guysv commented Feb 11, 2020

yes! its working! thanks alot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:windows type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants