Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to more correct relationship #523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

isaac-s
Copy link
Contributor

@isaac-s isaac-s commented Mar 23, 2017

At runtime, it doesn't matter whether the port is connected_to the network or contained_in, because the code looks for any kind of a relationship. So the original code works. However, it serves as a bad example because this relationship between a port and a network is incorrect. Among other things, a contained_in relationship between a port and a network would prevent the user from using scaling groups to include a Server and a Port in the same scaling group; that wouldn't pass validation, because Port would be contained_in a network and thus Server and Port have an ancestry conflict.

At runtime, it doesn't matter whether the port is `connected_to` the network or `contained_in`, because the code looks for any kind of a relationship. So the original code works. However, it serves as a bad example because this relationship between a port and a network is *incorrect*. Among other things, a `contained_in` relationship between a port and a network would prevent the user from using scaling groups to include a Server and a Port in the same scaling group; that wouldn't pass validation, because `Port` would be `contained_in` a network and thus `Server` and `Port` have an ancestry conflict.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant