CY-3420 Passive_deletes for executions #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehasdf
force-pushed
the
db-delete-cascade-1
branch
from
a25cade
to
8157879
Compare
Instead of passing just the name, allow passing the whole object. This will allow greater configurability, because now I can actually configure the backref when creating a one_to_many_relationship
When a deployment is deleted, the db cascades the execution by itself. No need to do it on the ORM side.
tehasdf
force-pushed
the
db-delete-cascade-1
branch
from
8157879
to
91334de
Compare
geokala
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting a deployment, the DB itself must do the cascade to executions,
because doing it on the python side takes too long, and that times out the request.
(with enough executions, of course)
Also, refactor passing in the backref into relationships a bit, so that this level
of configurability is actually possible