Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagon fails to validate correct wagons #112

Closed
mcouthon opened this issue Oct 22, 2017 · 2 comments
Closed

Wagon fails to validate correct wagons #112

mcouthon opened this issue Oct 22, 2017 · 2 comments

Comments

@mcouthon
Copy link

This is actually probably 2 issues.

Issue 1

Steps to reproduce:

  • wagon create pip
  • wagon validate <RESULTING_WAGON>
    The validation will fail.

Issue 2

The steps to reproduce are the same, but here the cause is clear - after pip install _s change to -s, and so this fails.
For example, here's a package on which create/validate will fail.

@nir0s
Copy link
Contributor

nir0s commented Oct 23, 2017

@mcouthon well, that's actually a pip thing. Even when the package is named target_mock, the name when you run pip freeze will show target-mock.

What we can do, is one of two things:

  1. Validate both _ and -.
  2. Make sure the package name is always with dashes instead of underscores. I think this is a dangerous option (albeit more aesthetic), so I wouldn't go for it.

@mcouthon
Copy link
Author

@nir0s Validating both seems sensible (and easy to implement).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants