Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for /internal/clear_cache #1388

Merged
merged 3 commits into from Nov 7, 2022
Merged

Conversation

abellotti
Copy link
Contributor

@abellotti abellotti commented Nov 7, 2022

  • Adding support for /internal/clear_cache, this triggers a cache clear for deleting all cached keys.

For: #1264

@abellotti abellotti marked this pull request as draft November 7, 2022 08:20
@abellotti abellotti changed the title Adding support for posting /internal/clear_cache Adding support for /internal/clear_cache Nov 7, 2022
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #1388 (bed79e4) into master (7254457) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1388      +/-   ##
==========================================
+ Coverage   97.36%   97.38%   +0.01%     
==========================================
  Files         202      203       +1     
  Lines       16712    16742      +30     
  Branches     1041     1041              
==========================================
+ Hits        16272    16304      +32     
+ Misses        285      284       -1     
+ Partials      155      154       -1     
Impacted Files Coverage Δ
cloudigrade/internal/urls.py 96.29% <ø> (ø)
...oudigrade/internal/tests/views/test_clear_cache.py 100.00% <100.00%> (ø)
cloudigrade/internal/views.py 91.94% <100.00%> (+0.28%) ⬆️
cloudigrade/api/tasks/synthesize.py 98.19% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7254457...bed79e4. Read the comment docs.

@abellotti abellotti force-pushed the 1264-support-cache-clear branch 2 times, most recently from f52f88b to 42c2ade Compare November 7, 2022 08:48
@abellotti abellotti marked this pull request as ready for review November 7, 2022 17:49
a cache clear for deleting all cached keys.
@abellotti
Copy link
Contributor Author

In addition to the LocMemCache py39 tests, I've manually tested running locally as well as port forwarding to an Ephemeral deployment (both Redis).

@abellotti abellotti enabled auto-merge (rebase) November 7, 2022 21:40
@abellotti
Copy link
Contributor Author

/retest

@abellotti abellotti merged commit 8a6366a into master Nov 7, 2022
@abellotti abellotti deleted the 1264-support-cache-clear branch November 7, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants