Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update <CldUploadButton> component #151

Conversation

max-programming
Copy link
Contributor

@max-programming max-programming commented Apr 10, 2024

This PR updates the example for the <CldUploadButton> component. The changes are as follows

  1. Updated Dependencies
  2. Added appropriate header and footer
  3. Customized the CldUploadButton, wrapped the demo in a card
  4. Added App Router example
  5. Removed unnecessary code
  6. Added Tailwind CSS
  7. Added toasts to show error and success messages
  8. Use CldImage and CldVideoPlayer to display the uploaded media

Copy link

vercel bot commented Apr 10, 2024

@max-programming is attempting to deploy a commit to the Cloudinary DevX Team on Vercel.

A member of the Team first needs to authorize it.

@colbyfayock
Copy link
Collaborator

i appreciate you adding Sonner, great library, but generally i want to keep the examples as MVP as possible, avoiding dependencies where we can, i think in this example we can maintain just updating the page with state to show the image/url

the rest looks good to me!

@max-programming
Copy link
Contributor Author

@colbyfayock Done

@colbyfayock
Copy link
Collaborator

hey @max-programming im not sure whats going on but im getting some funky conflicts after merging in your other upload widget example, can you take al ook at this? idk if we need to just delete it and readd it or osmething

@max-programming
Copy link
Contributor Author

@colbyfayock I opened #160 with the changes now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants