-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse SEO URLs & SEO Suffix #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 This PR is included in version @cloudinary-util/util-v2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@all-contributors please add @colbyfayock for code, doc |
I've put up a pull request to add @colbyfayock! 🎉 |
colbyfayock
pushed a commit
that referenced
this pull request
Feb 27, 2023
Adds @colbyfayock as a contributor for code, doc. This was requested by colbyfayock [in this comment](#19 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
# [@cloudinary-util/url-loader-v2.0.0](https://github.com/colbyfayock/cloudinary-util/compare/@cloudinary-util/url-loader-v1.4.1...@cloudinary-util/url-loader-v2.0.0) (2023-02-27) ### Features * Parse SEO URLs & SEO Suffix ([#19](#19)) ([acd1959](acd1959)), closes [#18](#18) * Sanitize Test ([#23](#23)) ([8ee4eb2](8ee4eb2)) * sanitizer on the SVG image ([#14](#14)) ([6a52c6c](6a52c6c)), closes [#13](#13)
🎉 This PR is included in version @cloudinary-util/url-loader-v2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
12 tasks
colbyfayock
added a commit
to cloudinary-community/next-cloudinary
that referenced
this pull request
Feb 27, 2023
# Description Upgrades packages to get SEO parsing and auto sanitization. cloudinary-community/cloudinary-util#19 ## Issue Ticket Number Fixes #145 Fixes #92 <!-- Specify above which issue this fixes by referencing the issue number (`#<ISSUE_NUMBER>`) or issue URL. --> <!-- Example: Fixes https://github.com/colbyfayock/next-cloudinary/issues/<ISSUE_NUMBER> --> ## Type of change <!-- Please select all options that are applicable. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Fix or improve the documentation - [ ] This change requires a documentation update # Checklist <!-- These must all be followed and checked. --> - [ ] I have followed the contributing guidelines of this project as mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md) - [ ] I have created an [issue](https://github.com/colbyfayock/next-cloudinary/issues) ticket for this PR - [ ] I have checked to ensure there aren't other open [Pull Requests](https://github.com/colbyfayock/next-cloudinary/pulls) for the same update/change? - [ ] I have performed a self-review of my own code - [ ] I have run tests locally to ensure they all pass - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes needed to the documentation
cham74
added a commit
to cham74/next-image-delivery
that referenced
this pull request
Dec 23, 2023
# Description Upgrades packages to get SEO parsing and auto sanitization. cloudinary-community/cloudinary-util#19 ## Issue Ticket Number Fixes #145 Fixes #92 <!-- Specify above which issue this fixes by referencing the issue number (`#<ISSUE_NUMBER>`) or issue URL. --> <!-- Example: Fixes https://github.com/colbyfayock/next-cloudinary/issues/<ISSUE_NUMBER> --> ## Type of change <!-- Please select all options that are applicable. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Fix or improve the documentation - [ ] This change requires a documentation update # Checklist <!-- These must all be followed and checked. --> - [ ] I have followed the contributing guidelines of this project as mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md) - [ ] I have created an [issue](https://github.com/colbyfayock/next-cloudinary/issues) ticket for this PR - [ ] I have checked to ensure there aren't other open [Pull Requests](https://github.com/colbyfayock/next-cloudinary/pulls) for the same update/change? - [ ] I have performed a self-review of my own code - [ ] I have run tests locally to ensure they all pass - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes needed to the documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cloudinary allows the ability to create SEO friendly URLs using the SEO Suffix option
This changes the asset type for example /image/upload => /images
This PR allows for the parsing of this and adds the ability to pass in an SEO suffix.
This also updates version management in how it parses and now allows someone to pass in a version
Issue Ticket Number
Fixes #18
Type of change
Checklist
BREAKING CHANGES: "version" is returned as a number from parseUrl. "id" is now named "publicId" when returned from parseUrl