Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse SEO URLs & SEO Suffix #19

Merged
merged 7 commits into from
Feb 27, 2023
Merged

Parse SEO URLs & SEO Suffix #19

merged 7 commits into from
Feb 27, 2023

Conversation

colbyfayock
Copy link
Collaborator

@colbyfayock colbyfayock commented Feb 26, 2023

Description

Cloudinary allows the ability to create SEO friendly URLs using the SEO Suffix option

This changes the asset type for example /image/upload => /images

This PR allows for the parsing of this and adds the ability to pass in an SEO suffix.

This also updates version management in how it parses and now allows someone to pass in a version

options: {
   seoSuffix: 'my-friendly-url',
  version: 1234
}

Issue Ticket Number

Fixes #18

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

BREAKING CHANGES: "version" is returned as a number from parseUrl. "id" is now named "publicId" when returned from parseUrl

@colbyfayock colbyfayock merged commit acd1959 into main Feb 27, 2023
@colbyfayock colbyfayock deleted the bug/18-seo-suffix branch February 27, 2023 01:51
github-actions bot pushed a commit that referenced this pull request Feb 27, 2023
# [@cloudinary-util/util-v2.0.0](https://github.com/colbyfayock/cloudinary-util/compare/@cloudinary-util/util-v1.2.3...@cloudinary-util/util-v2.0.0) (2023-02-27)

### Features

* Parse SEO URLs & SEO Suffix ([#19](#19)) ([acd1959](acd1959)), closes [#18](#18)
@github-actions
Copy link

🎉 This PR is included in version @cloudinary-util/util-v2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@colbyfayock
Copy link
Collaborator Author

@all-contributors please add @colbyfayock for code, doc

@allcontributors
Copy link
Contributor

@colbyfayock

I've put up a pull request to add @colbyfayock! 🎉

colbyfayock pushed a commit that referenced this pull request Feb 27, 2023
Adds @colbyfayock as a contributor for code, doc.

This was requested by colbyfayock [in this
comment](#19 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Feb 27, 2023
# [@cloudinary-util/url-loader-v2.0.0](https://github.com/colbyfayock/cloudinary-util/compare/@cloudinary-util/url-loader-v1.4.1...@cloudinary-util/url-loader-v2.0.0) (2023-02-27)

### Features

* Parse SEO URLs & SEO Suffix ([#19](#19)) ([acd1959](acd1959)), closes [#18](#18)
* Sanitize Test ([#23](#23)) ([8ee4eb2](8ee4eb2))
* sanitizer on the SVG image ([#14](#14)) ([6a52c6c](6a52c6c)), closes [#13](#13)
@github-actions
Copy link

🎉 This PR is included in version @cloudinary-util/url-loader-v2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

colbyfayock added a commit to cloudinary-community/next-cloudinary that referenced this pull request Feb 27, 2023
# Description

Upgrades packages to get SEO parsing and auto sanitization.

cloudinary-community/cloudinary-util#19

## Issue Ticket Number

Fixes #145 
Fixes #92 

<!-- Specify above which issue this fixes by referencing the issue
number (`#<ISSUE_NUMBER>`) or issue URL. -->
<!-- Example: Fixes
https://github.com/colbyfayock/next-cloudinary/issues/<ISSUE_NUMBER> -->

## Type of change

<!-- Please select all options that are applicable. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Fix or improve the documentation
- [ ] This change requires a documentation update


# Checklist

<!-- These must all be followed and checked. -->

- [ ] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [ ] I have created an
[issue](https://github.com/colbyfayock/next-cloudinary/issues) ticket
for this PR
- [ ] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/colbyfayock/next-cloudinary/pulls) for the
same update/change?
- [ ] I have performed a self-review of my own code
- [ ] I have run tests locally to ensure they all pass
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes needed to the documentation
cham74 added a commit to cham74/next-image-delivery that referenced this pull request Dec 23, 2023
# Description

Upgrades packages to get SEO parsing and auto sanitization.

cloudinary-community/cloudinary-util#19

## Issue Ticket Number

Fixes #145 
Fixes #92 

<!-- Specify above which issue this fixes by referencing the issue
number (`#<ISSUE_NUMBER>`) or issue URL. -->
<!-- Example: Fixes
https://github.com/colbyfayock/next-cloudinary/issues/<ISSUE_NUMBER> -->

## Type of change

<!-- Please select all options that are applicable. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Fix or improve the documentation
- [ ] This change requires a documentation update


# Checklist

<!-- These must all be followed and checked. -->

- [ ] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [ ] I have created an
[issue](https://github.com/colbyfayock/next-cloudinary/issues) ticket
for this PR
- [ ] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/colbyfayock/next-cloudinary/pulls) for the
same update/change?
- [ ] I have performed a self-review of my own code
- [ ] I have run tests locally to ensure they all pass
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes needed to the documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] URL Regex does not support SEO suffixes
1 participant