Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improve Readme images #38

Closed
3t8 opened this issue Oct 18, 2022 · 2 comments · Fixed by #39
Closed

[Feature] Improve Readme images #38

3t8 opened this issue Oct 18, 2022 · 2 comments · Fixed by #39
Assignees
Labels

Comments

@3t8
Copy link
Contributor

3t8 commented Oct 18, 2022

Feature Request

Is your feature request related to a problem? Please describe.

The Netlify image in the current README is hardly visible if using dark mode

dark_mode

Describe the solution you'd like

It would be nice to have the image change dynamically, adapting to the user's theme

Dark mode would look like this:

dark_mode

I'd be more than happy to work on it if it gets approved

@colbyfayock
Copy link
Collaborator

go for it :)

colbyfayock pushed a commit that referenced this issue Oct 19, 2022
# Description

Logo images in README change dynamically, adapting to the user's theme

## Issue Ticket Number

<!-- Specifiy which issue this fixes by referencing the issue number
(`#11`) or issue URL. -->
<!-- Example: Fixes
#1 -->

Fixes #38 

## Type of change

<!-- Please select all options that are applicable. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update


# Checklist

<!-- These must all be followed and checked. -->

- [x] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [x] I have created an
[issue](https://github.com/colbyfayock/netlify-plugin-cloudinary/issues)
ticket for this PR
- [x] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/colbyfayock/netlify-plugin-cloudinary/pulls)
for the same update/change?
- [x] I have performed a self-review of my own code
- [x] I have run tests locally to ensure they all pass
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes needed to the documentation
@github-actions
Copy link

🎉 This issue has been resolved in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

matiasfha pushed a commit to matiasfha/netlify-plugin-cloudinary that referenced this issue Sep 23, 2023
…ary-community#38) (cloudinary-community#39)

# Description

Logo images in README change dynamically, adapting to the user's theme

## Issue Ticket Number

<!-- Specifiy which issue this fixes by referencing the issue number
(`cloudinary-community#11`) or issue URL. -->
<!-- Example: Fixes
cloudinary-community#1 -->

Fixes cloudinary-community#38 

## Type of change

<!-- Please select all options that are applicable. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update


# Checklist

<!-- These must all be followed and checked. -->

- [x] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [x] I have created an
[issue](https://github.com/colbyfayock/netlify-plugin-cloudinary/issues)
ticket for this PR
- [x] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/colbyfayock/netlify-plugin-cloudinary/pulls)
for the same update/change?
- [x] I have performed a self-review of my own code
- [x] I have run tests locally to ensure they all pass
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes needed to the documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants