Skip to content

Commit

Permalink
feat: Fixes encoding and missing signature characters (#232)
Browse files Browse the repository at this point in the history
# Description

- Fixes issue with double encoding
cloudinary-community/cloudinary-util#60

- Fixes issue where signature was not allowing special characters `-_`
cloudinary-community/cloudinary-util#61

## Issue Ticket Number

Fixes #219 

<!-- Specify above which issue this fixes by referencing the issue
number (`#<ISSUE_NUMBER>`) or issue URL. -->
<!-- Example: Fixes
https://github.com/colbyfayock/next-cloudinary/issues/<ISSUE_NUMBER> -->

## Type of change

<!-- Please select all options that are applicable. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Fix or improve the documentation
- [ ] This change requires a documentation update


# Checklist

<!-- These must all be followed and checked. -->

- [ ] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [ ] I have created an
[issue](https://github.com/colbyfayock/next-cloudinary/issues) ticket
for this PR
- [ ] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/colbyfayock/next-cloudinary/pulls) for the
same update/change?
- [ ] I have performed a self-review of my own code
- [ ] I have run tests locally to ensure they all pass
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes needed to the documentation
  • Loading branch information
colbyfayock committed Jul 18, 2023
1 parent 68956e3 commit 4b520ce
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 11 deletions.
4 changes: 2 additions & 2 deletions next-cloudinary/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"test:app": "NEXT_PUBLIC_CLOUDINARY_CLOUD_NAME=\"test\" yarn build && cd tests/nextjs-app && yarn build"
},
"dependencies": {
"@cloudinary-util/url-loader": "^3.9.0",
"@cloudinary-util/util": "^2.1.0",
"@cloudinary-util/url-loader": "^3.9.1",
"@cloudinary-util/util": "^2.2.1",
"@cloudinary/url-gen": "^1.10.1"
},
"devDependencies": {
Expand Down
23 changes: 14 additions & 9 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -943,18 +943,23 @@
resolved "https://registry.yarnpkg.com/@braintree/sanitize-url/-/sanitize-url-6.0.2.tgz#6110f918d273fe2af8ea1c4398a88774bb9fc12f"
integrity sha512-Tbsj02wXCbqGmzdnXNk0SOF19ChhRU70BsroIi4Pm6Ehp56in6vch94mfbdQ17DozxkL3BAVjbZ4Qc1a0HFRAg==

"@cloudinary-util/url-loader@^3.9.0":
version "3.9.0"
resolved "https://registry.yarnpkg.com/@cloudinary-util/url-loader/-/url-loader-3.9.0.tgz#c3b7c40f525aba8c58edbdf784addc3c51e3e642"
integrity sha512-DJiu+a3Mr2GEyjAo4Gy2KWX0YoXoP0CFp2jvw8+3gJj7wvmIb7mcjRk1yHSGIyJcolb0uR+tWGO6KVhStpreMg==
"@cloudinary-util/url-loader@^3.9.1":
version "3.9.1"
resolved "https://registry.yarnpkg.com/@cloudinary-util/url-loader/-/url-loader-3.9.1.tgz#71456ceb289de08c27bb8688b3733066a1ec5654"
integrity sha512-5j91AbiNIIyWz24hzrpKKEZut08j9px5xGTSwqFS1c2aadBOirOAOY8C23SzJSQNmuBDDZnHgH83EWfrZj3leA==
dependencies:
"@cloudinary-util/util" "2.1.0"
"@cloudinary-util/util" "2.2.0"
"@cloudinary/url-gen" "^1.10.1"

"@cloudinary-util/util@2.1.0", "@cloudinary-util/util@^2.1.0":
version "2.1.0"
resolved "https://registry.yarnpkg.com/@cloudinary-util/util/-/util-2.1.0.tgz#1f8152b228cdd92e8ccc1fa0200d4eeeb6ef73ae"
integrity sha512-PGjVxyhhOP8IaD6uawXzfDnI8ArPqpiLfIXc8TEjhv3CGhDFBAM3dCT3xeAgg+92sQsx/AN74j+qckdWPfoO6w==
"@cloudinary-util/util@2.2.0":
version "2.2.0"
resolved "https://registry.yarnpkg.com/@cloudinary-util/util/-/util-2.2.0.tgz#754f474d69f878249478fb98e1217a219063f482"
integrity sha512-FCEwoswGO9z5BmSY0iJLos8U4bmNGIy7Ap8KoJRJ3Vn2STqx+ilDzYMPJTQ8FVcYD1iDajMs52xg00oWO99pNg==

"@cloudinary-util/util@^2.2.1":
version "2.2.1"
resolved "https://registry.yarnpkg.com/@cloudinary-util/util/-/util-2.2.1.tgz#c482d9321d37d921b347858a121c161b68782bd3"
integrity sha512-MEIqn5WtPP3mxSMTNNfpqlGS1UquAXcjmVdY/t/edD/ZWVjI85viBiOMIuF0W6n6UF5gTstLymfQNYx0YO/GZg==

"@cloudinary/transformation-builder-sdk@^1.2.7":
version "1.2.8"
Expand Down

1 comment on commit 4b520ce

@vercel
Copy link

@vercel vercel bot commented on 4b520ce Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.