Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: Fix code block dark mode #60

Merged

Conversation

leovoon
Copy link
Contributor

@leovoon leovoon commented Oct 4, 2023

Description

Add a dark mode background to the code blocks when the user toggles dark mode or when their preferred color scheme is set to dark. Choose a background color that has the same tone as the suggested color.

Issue Ticket Number

Fixes #53

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

I'm participating in Hacktoberfest.

@vercel
Copy link

vercel bot commented Oct 4, 2023

@leovoon is attempting to deploy a commit to the Cloudinary DevX Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-cloudinary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 5:29pm

}

/* Prefer color scheme: dark */
@media (prefers-color-scheme: dark) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This takes precedence over the user's decision, If the user chooses a light theme but the OS preferred scheme is dark then this media query takes over.

CleanShot 2023-10-09 at 10 01 34@2x

Copy link
Contributor

@matiasfha matiasfha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work and collaboration. I noticed a minor problem with the media query that was used. If you could address this, we would be able to accept your PR as a complete fix.

Copy link
Contributor

@matiasfha matiasfha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
Thanks for your collaboration!

@matiasfha
Copy link
Contributor

@all-contributors
please add @leovoon for code

@allcontributors
Copy link
Contributor

@matiasfha

I've put up a pull request to add @leovoon! 🎉

@matiasfha matiasfha merged commit e4ab138 into cloudinary-community:main Oct 11, 2023
2 of 3 checks passed
@colbyfayock
Copy link
Contributor

@leovoon congrats on the merged PR! since it's officially October, you've always qualified for Hacktoberfest swag! please email hacktoberfest@cloudinary.com with your github username and a link to your contribution where I'll follow up to request more information for getting you your swag

https://cloudinary.com/blog/hacktoberfest-celebrate-open-source-sdks

@leovoon
Copy link
Contributor Author

leovoon commented Oct 11, 2023

@leovoon congrats on the merged PR! since it's officially October, you've always qualified for Hacktoberfest swag! please email hacktoberfest@cloudinary.com with your github username and a link to your contribution where I'll follow up to request more information for getting you your swag

https://cloudinary.com/blog/hacktoberfest-celebrate-open-source-sdks

Thanks!

@github-actions
Copy link

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code examples background on the doc site when site is on dark mode
3 participants