New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs]: Fix code block dark mode #60
[docs]: Fix code block dark mode #60
Conversation
@leovoon is attempting to deploy a commit to the Cloudinary DevX Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
docs/static/one-light.prism.css
Outdated
} | ||
|
||
/* Prefer color scheme: dark */ | ||
@media (prefers-color-scheme: dark) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work and collaboration. I noticed a minor problem with the media query that was used. If you could address this, we would be able to accept your PR as a complete fix.
…hen dark is preferred
fff32bc
to
d147360
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Thanks for your collaboration!
@all-contributors |
I've put up a pull request to add @leovoon! 🎉 |
@leovoon congrats on the merged PR! since it's officially October, you've always qualified for Hacktoberfest swag! please email hacktoberfest@cloudinary.com with your github username and a link to your contribution where I'll follow up to request more information for getting you your swag https://cloudinary.com/blog/hacktoberfest-celebrate-open-source-sdks |
Thanks! |
🎉 This PR is included in version 1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Add a dark mode background to the code blocks when the user toggles dark mode or when their preferred color scheme is set to dark. Choose a background color that has the same tone as the suggested color.
Issue Ticket Number
Fixes #53
Type of change
Checklist
I'm participating in Hacktoberfest.