Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support quality_override param for update and explicit api #242

Merged
merged 2 commits into from
Feb 23, 2020
Merged

Support quality_override param for update and explicit api #242

merged 2 commits into from
Feb 23, 2020

Conversation

shedar
Copy link
Contributor

@shedar shedar commented Mar 11, 2019

Replaces #190

@shedar shedar mentioned this pull request Mar 11, 2019
Closed
@shedar shedar force-pushed the feature/quality-override-es6 branch from d1948f8 to f93ba8a Compare March 11, 2019 15:13
@asisayag2 asisayag2 requested a review from tocker March 11, 2019 22:50
@asisayag2
Copy link
Contributor

@shedar , CI failed for this change. please check

@shedar
Copy link
Contributor Author

shedar commented Mar 12, 2019

@asisayag2 , it failed in 1 of 4 runs on search api tests. It's not related to my changes

@asisayag2 asisayag2 requested review from strausr and removed request for tocker September 26, 2019 15:28
@strausr strausr merged commit 5d1c24c into master Feb 23, 2020
@snyk-bot snyk-bot mentioned this pull request Apr 8, 2020
Open
@patrick-tolosa patrick-tolosa deleted the feature/quality-override-es6 branch July 5, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strausr strausr strausr approved these changes

@asisayag2 asisayag2 asisayag2 approved these changes

Assignees

@strausr strausr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shedar @asisayag2 @strausr