Add provisioning api #343
Merged
Add provisioning api #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
patrick-tolosa
commented
Feb 10, 2020
patrick-tolosa
commented
- Implement the Provisioning API.
- Test coverage 100% of required arguments - (did not implement a test for all optional arguments)
- Created CRUD apis for USERS, SUB_ACCOUNTS and USER_GROUPS
- Happy to add more tests if needed
patrick-tolosa
requested review from
strausr,
const-cloudinary,
asisayag2 and
a user
patrick-tolosa
commented
Feb 11, 2020
patrick-tolosa
commented
Feb 11, 2020
patrick-tolosa
commented
Feb 11, 2020
strausr
requested changes
Feb 13, 2020
strausr
approved these changes
Feb 16, 2020
asisayag2
reviewed
Feb 16, 2020
asisayag2
approved these changes
Feb 17, 2020
jackieros
requested changes
Feb 20, 2020
jackieros
reviewed
Feb 27, 2020
There was a problem hiding this comment.
@patrick-tolosa Even just skimming, a few new issues jumped out at me. After implementing these (assuming you agree with all), feel free to merge. (No need for another review :-)
lib/provisioning/account.js
Outdated
| * @param sub_account_id {string} - The ID of the sub-account. | ||
| * @param [name] {string} - The display name as shown in the management console. | ||
| * @param [cloud_name] {string} - A case-insensitive cloud name comprised of alphanumeric and underscore characters. | ||
| * Use with caution - generates an error if the cloud name is not unique across all |
There was a problem hiding this comment.
Suggested change
| * Use with caution - generates an error if the cloud name is not unique across all |
There was a problem hiding this comment.
This is from @MeirFeinberg , he wanted to emphasise since it returns strange error, but yeah can be removed
jifeon
reviewed
Sep 11, 2020
Comment on lines
+349
to
+350
| provisioning_api_key: string; | ||
| provisioning_api_secret: string; |
There was a problem hiding this comment.
Hi @patrick-tolosa! Why these two are required? My type checking start complaining about them.
There was a problem hiding this comment.
Hi,
Thanks for bringing this up, I've opened #451 to address it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.