Update cloudinary.js to copy over options instead of mutating #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using in the passed in `option` argument in `.image` and `.video`, we first copy it over so there is no way we mutate the passed in option object.
|
Thanks for catching this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using in the passed in
optionsargument in.image, we use_.extendto make a shallow copy of theoptionsobject passed in. Therefore, there will be no way of mutating theoptionsobject directly.This happens in
.videotoo but theoptionsare deep cloned later on. I still used.extendas I do not know if anything before the deep clone mutatesoptions.Added tests as well :)
Issue: #55
Side note: We are not deep copying so deeper objects could possibly be mutated. Not worrying about this unless objects to get mutated at a deeper level.