Asset selection in rules #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itor into asset-selection-in-rules
oxisto
reviewed
Aug 14, 2019
| // take the first one | ||
| return this.conditions.get(0).getAssetType(); | ||
| return this.conditions.get(0).getAssetType().getField(); |
There was a problem hiding this comment.
This creates a problem since only the first condition will be evaluated regarding its applicability but in future we are reworking this anyway in #62
oxisto
requested changes
Aug 14, 2019
clouditor-engine-core/src/main/java/io/clouditor/assurance/RuleService.java
Show resolved
Hide resolved
clouditor-engine-core/src/main/java/io/clouditor/assurance/ccl/AssetType.java
Outdated
Show resolved
Hide resolved
clouditor-engine-core/src/main/java/io/clouditor/assurance/ccl/AssetType.java
Outdated
Show resolved
Hide resolved
oxisto
approved these changes
Aug 14, 2019
|
Fixes #45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
beforeandafteroperators to define rules concerning dates in the future, e.g.user has expiry before 100 days in all accessKeys(meaning the expiry date is before today's date plus 100 days)youngerandolderoperators to define rules concerning the age of assets, e.g.user has createDate younger 100 days in all accessKeys(meaning the creation date is after today's date minus 100 days)