Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GetMetricConfiguration description #815

Merged
merged 23 commits into from Nov 7, 2022
Merged

Conversation

anatheka
Copy link
Member

@anatheka anatheka commented Oct 14, 2022

  • UpdateMetricConfiguration
    • Add request validation for metricId and cloudServiceId, Add tests!
    • isDefault is not updated, if not available in request -> set to false
    • grpc does not returns some fields (e.g., isDefault, Timestamp)
    • updatedAt is always set to 1970-01-01T00:00:00Z
  • GetMetricConfiguration: MetricId and cloudServiceId not available after initialization (curl call)

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #815 (3c39fc2) into main (84cf8fa) will increase coverage by 0.43%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
+ Coverage   81.57%   82.00%   +0.43%     
==========================================
  Files          85       86       +1     
  Lines        6883     6942      +59     
==========================================
+ Hits         5615     5693      +78     
+ Misses        982      965      -17     
+ Partials      286      284       -2     
Flag Coverage Δ
unittests 82.00% <95.23%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
service/orchestrator/metrics.go 82.58% <75.00%> (-0.54%) ⬇️
api/assessment/metric.go 100.00% <100.00%> (+12.94%) ⬆️
api/orchestrator/orchestrator.go 100.00% <100.00%> (ø)
service/orchestrator/orchestrator.go 83.40% <0.00%> (+4.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anatheka anatheka marked this pull request as draft October 14, 2022 20:07
@anatheka anatheka marked this pull request as ready for review October 31, 2022 13:48
@anatheka
Copy link
Member Author

The following should be checked in an separate PR/Issue.

UpdateMetricConfiguration

  • isDefault is not updated, if not available in request -> set to false
  • grpc does not returns some fields (e.g., isDefault, Timestamp)
  • updatedAt is always set to 1970-01-01T00:00:00Z

GetMetricConfiguration:

  • MetricId and cloudServiceId not available after initialization (curl call)

api/assessment/metric.go Outdated Show resolved Hide resolved
api/assessment/metric.go Outdated Show resolved Hide resolved
api/orchestrator/orchestrator.go Outdated Show resolved Hide resolved
api/orchestrator/orchestrator.proto Outdated Show resolved Hide resolved
@anatheka anatheka marked this pull request as draft November 4, 2022 18:26
@anatheka anatheka marked this pull request as ready for review November 7, 2022 12:28
api/assessment/metric.go Outdated Show resolved Hide resolved
api/orchestrator/orchestrator.go Outdated Show resolved Hide resolved
api/orchestrator/orchestrator.go Outdated Show resolved Hide resolved
api/orchestrator/orchestrator.go Outdated Show resolved Hide resolved
api/orchestrator/orchestrator.go Outdated Show resolved Hide resolved
@oxisto oxisto merged commit 80b2df4 into main Nov 7, 2022
@oxisto oxisto deleted the update_getMetricConfiguration branch November 7, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants