New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GetMetricConfiguration description #815
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
anatheka
commented
Oct 14, 2022
•
edited
edited
- UpdateMetricConfiguration
- Add request validation for metricId and cloudServiceId, Add tests!
- isDefault is not updated, if not available in request -> set to false
- grpc does not returns some fields (e.g., isDefault, Timestamp)
- updatedAt is always set to 1970-01-01T00:00:00Z
- GetMetricConfiguration: MetricId and cloudServiceId not available after initialization (curl call)
Codecov Report
@@ Coverage Diff @@
## main #815 +/- ##
==========================================
+ Coverage 81.57% 82.00% +0.43%
==========================================
Files 85 86 +1
Lines 6883 6942 +59
==========================================
+ Hits 5615 5693 +78
+ Misses 982 965 -17
+ Partials 286 284 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The following should be checked in an separate PR/Issue. UpdateMetricConfiguration
GetMetricConfiguration:
|
4 tasks
oxisto
reviewed
Oct 31, 2022
…clouditor into update_getMetricConfiguration
oxisto
reviewed
Nov 7, 2022
…clouditor into update_getMetricConfiguration
oxisto
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.