Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed Swagger-UI info the Dashboard #38

Closed
tzach opened this issue Sep 1, 2014 · 6 comments
Closed

Embed Swagger-UI info the Dashboard #38

tzach opened this issue Sep 1, 2014 · 6 comments

Comments

@tzach
Copy link
Member

tzach commented Sep 1, 2014

Swagger-UI should become integral part of the dashboard:

  • Keep the header of the dashboard
  • Not refresh the page
  • Have similar style, color, font, etc

The current header of the swagger-ui (see picture below) include input text fields for choosing a JSON file and API Key.
Both are not required for the embedded swagger-ui.

image

@dzautner
Copy link
Contributor

dzautner commented Sep 2, 2014

What should be the URL of the Swagger-UI? Should it remain the API base path, as it is now?

@tzach tzach added the UX label Sep 2, 2014
@tzach
Copy link
Member Author

tzach commented Sep 2, 2014

No, it can be part of the dashboard.
I suggest

dashboard/rest

@amnonh @slivne any objections?

@tzach
Copy link
Member Author

tzach commented Sep 21, 2014

@amnon @dzautner can we complete this task?
Once we do, the dashboard URL can become the root one (not dashboard)

@amnon
Copy link

amnon commented Sep 21, 2014

I'm not the Amnon you want! :)

On Sun, Sep 21, 2014 at 4:21 PM, Tzach Livyatan notifications@github.com
wrote:

@amnon https://github.com/amnon @dzautner https://github.com/dzautner
can we complete this task?
Once we do, the dashboard URL can become the root one (not dashboard)


Reply to this email directly or view it on GitHub
#38 (comment)
.

@tzach
Copy link
Member Author

tzach commented Sep 21, 2014

@amnonh this is for you
Sorry @amnon (feel free to join the project ;)

@tzach tzach added this to the OSv 0.14 milestone Oct 7, 2014
@dzautner dzautner mentioned this issue Oct 10, 2014
@tzach
Copy link
Member Author

tzach commented Oct 14, 2014

Look good!
@amnonh can we now move the dashboard to the root path?

@tzach tzach closed this as completed Oct 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants