Merge 5020969 into c27b846

cloudmarker/test/test_mongodbstore.py

@@ -0,0 +1,123 @@
+"""Tests for mongodbstore plugin."""
+
+
+import unittest
+from unittest import mock
+
+from cloudmarker.stores import mongodbstore
+
+
+class MongoDBStoreTest(unittest.TestCase):
+    """Tests for mongodbstore plugin."""
+
+    @mock.patch('cloudmarker.stores.mongodbstore.MongoClient')
+    def test_write_without_flush(self, mock_client):
+        # Set buffer size of 3.
+        store = mongodbstore.MongoDBStore(buffer_size=3)
+
+        # But insert only 2 records.
+        for i in range(2):
+            record = {'record_type': 'foo', 'i': i}
+            store.write(record)
+
+        # Verify that buffer is not being flushed via client.
+        mock_method = mock_client()['fake_db']['fake_record_type'].insert_many
+        mock_method.assert_not_called()
+
+    @mock.patch('cloudmarker.stores.mongodbstore.MongoClient')
+    def test_write_with_flush(self, mock_client):
+        # Set buffer size of 3.
+        store = mongodbstore.MongoDBStore(buffer_size=3)
+
+        # Then insert 3 records.
+        for i in range(3):
+            record = {'record_type': 'foo', 'i': i}
+            store.write(record)
+
+        # Verify that buffer is being flushed via client.
+        mock_method = mock_client()['fake_db']['fake_record_type'].insert_many
+        mock_method.assert_called_once_with(mock.ANY, ordered=mock.ANY)
+
+    @mock.patch('cloudmarker.stores.mongodbstore.MongoClient')
+    def test_done(self, mock_client):
+        # Write only one record to store with default buffer size.
+        store = mongodbstore.MongoDBStore()
+        store.write({'record_type': 'foo', 'i': 0})
+
+        # Call store's done(), so that it flushes the pending buffer.
+        store.done()
+
+        # Verify that the pending buffer is flushed via client.
+        mock_method = mock_client()['fake_db']['fake_record_type'].insert_many
+        mock_method.assert_called_once_with(mock.ANY, ordered=mock.ANY)
+
+        # Verify that client is being closed.
+        mock_method = mock_client().close
+        mock_method.assert_called_once_with()
+
+    @mock.patch('cloudmarker.stores.mongodbstore.MongoClient')
+    def test_validation_with_missing_collection(self, mock_client):
+        # Get a mock that reprensets a DB.
+        mock_db = mock_client()['fake_db']
+
+        # Configure mock DB to pretend that it has some fake collections.
+        collections = ['foo_collection', 'bar_collection']
+        mock_db.list_collection_names = mock.Mock(return_value=collections)
+
+        # Configure a mock validator model for a missing collection.
+        mock_model = mock.Mock()
+        mock_model.collection = mock.Mock(return_value='baz_collection')
+
+        # Create store with the mock model.
+        mongodbstore.MongoDBStore(models=[mock_model])
+
+        # Verify that the client was used to create a collection.
+        mock_db.create_collection.assert_called_once_with(
+            mock_model.collection(),
+            validator=mock_model.validator(),
+            validationAction=mock_model.enforce())
+
+        # Verify that model's methods were exercised.
+        mock_model.collection.assert_called_with()
+        mock_model.validator.assert_called_with()
+        mock_model.enforce.assert_called_with()
+
+    @mock.patch('cloudmarker.stores.mongodbstore.MongoClient')
+    def test_validations_with_existing_collection(self, mock_client):
+        # Get a mock that reprensets a DB.
+        mock_db = mock_client()['fake_db']
+
+        # Configure mock DB to pretend that it has some fake collections.
+        collections = ['foo_collection', 'bar_collection']
+        mock_db.list_collection_names = mock.Mock(return_value=collections)
+
+        # Configure mock DB to pretend that it has the above collections.
+        mock_db.list_collection_names = mock.Mock(return_value=collections)
+
+        # Configure a mock validator model for an existing collection.
+        mock_model = mock.Mock()
+        mock_model.collection = mock.Mock(return_value='foo_collection')
+
+        # Create store with the mock model.
+        mongodbstore.MongoDBStore(models=[mock_model])
+
+        # Verify that the client was _not_ used to create a collection.
+        mock_db.create_collection.assert_not_called()
+
+        # Verify that model's validation methods were _not_ exercised.
+        mock_model.validator.assert_not_called()
+        mock_model.enforce.assert_not_called()
+
+    @mock.patch('cloudmarker.stores.mongodbstore.MongoClient')
+    def test_bulk_write_error(self, mock_client):
+        from pymongo import errors
+
+        # Configure the mock client such that it raises BulkWriteError
+        # on insertion of records.
+        mock_method = mock.Mock(side_effect=errors.BulkWriteError(None))
+        mock_client()['fake_db']['fake_record_type'].insert_many = mock_method
+
+        # Ensure that the error is handled gracefully without a crash.
+        store = mongodbstore.MongoDBStore()
+        store.write({'record_type': 'foo', 'i': 0})
+        store.done()

pylama.ini

@@ -23,11 +23,12 @@ ignore = R0913
 # R0913 Too many arguments (7/5)
 
 [pylama:cloudmarker/test/test_*.py]
-ignore = D102,C0111,R0903
+ignore = D102,C0111,R0903,R0201
 
 # D102 Missing docstring in public method [pydocstyle]
 # C0111 Missing method docstring [pylint]
 # R0903 Too few public methods (0/2) [pylint]
+# R0201 Method could be a function [pylint]
 
 [pylama:docs/conf.py]
 ignore = W0622