Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

future work: delete "active flow" collection after flow ends #25

Open
robludwig opened this issue May 2, 2019 · 3 comments
Open

future work: delete "active flow" collection after flow ends #25

robludwig opened this issue May 2, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@robludwig
Copy link
Collaborator

As explained in the DB section of the manual, we have a new collection when users run a workflow, which we overwrite every time users run that workflow. We should consider

  • summarizing the status of the collection when the flow finishes and then
  • deleting the collection to save space
@robludwig
Copy link
Collaborator Author

In fact, we could probably harmonize the database a little more. We really only need one workflow collection for definitions and one for active, with a discriminator key called "workflow" that says which node each one is related to. This would need some work if we wanted to be able to run multiple flows at once though. Creating the active collection uses mongodb's $out feature which creates a collection and always overwrites it

@laszewsk
Copy link
Member

laszewsk commented May 2, 2019 via email

@robludwig
Copy link
Collaborator Author

robludwig commented May 2, 2019

yes, the current setup supports that but is inefficient. Future work could make it more efficient as described above, but would have to preserve this functionality

perhaps one collection for all flows, plus one collection per running flow

@laszewsk laszewsk added the enhancement New feature or request label May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants