feat: disable ALTER SYSTEM by default

Closes #3544
cloudnative-pg · Dec 13, 2023 · 835f826 · 835f826
1 parent 220393d
commit 835f826
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/api/v1/cluster_types.go b/api/v1/cluster_types.go
@@ -1181,8 +1181,7 @@ type PostgresConfiguration struct {
 	// If this parameter is true, the user will be able to invoke `ALTER SYSTEM`
 	// on this CloudNativePG Cluster.
 	// This should only be used for debugging and troubleshooting.
-	// Defaults to true.
-	// +kubebuilder:default:=true
+	// Defaults to false.
 	// +optional
 	EnableAlterSystem bool `json:"enableAlterSystem,omitempty"`
 }

diff --git a/config/crd/bases/postgresql.cnpg.io_clusters.yaml b/config/crd/bases/postgresql.cnpg.io_clusters.yaml
@@ -2715,11 +2715,10 @@ spec:
                 description: Configuration of the PostgreSQL server
                 properties:
                   enableAlterSystem:
-                    default: true
                     description: If this parameter is true, the user will be able
                       to invoke `ALTER SYSTEM` on this CloudNativePG Cluster. This
                       should only be used for debugging and troubleshooting. Defaults
-                      to true.
+                      to false.
                     type: boolean
                   ldap:
                     description: Options to specify LDAP configuration

diff --git a/docs/src/cloudnative-pg.v1.md b/docs/src/cloudnative-pg.v1.md
@@ -3554,7 +3554,7 @@ big enough to simulate an infinite timeout</p>
    <p>If this parameter is true, the user will be able to invoke <code>ALTER SYSTEM</code>
 on this CloudNativePG Cluster.
 This should only be used for debugging and troubleshooting.
-Defaults to true.</p>
+Defaults to false.</p>
 </td>
 </tr>
 </tbody>