chore: linearize

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>

internal/management/controller/instance_controller.go

@@ -133,9 +133,6 @@ func (r *InstanceReconciler) Reconcile(
 	}
 	reloadNeeded = reloadNeeded || reloadConfigNeeded
 
-	// Reconcile postgresql.auto.conf file
-	r.reconcileAutoConf(ctx, cluster)
-
 	// here we execute initialization tasks that need to be executed only on the first reconciliation loop
 	if !r.firstReconcileDone.Load() {
 		if err = r.initialize(ctx, cluster); err != nil {
@@ -144,6 +141,10 @@ func (r *InstanceReconciler) Reconcile(
 		r.firstReconcileDone.Store(true)
 	}
 
+	// Reconcile postgresql.auto.conf file. This operation must be after the initialize() call
+	// because it could interfere with pg_rewind execution
+	r.reconcileAutoConf(ctx, cluster)
+
 	// Reconcile cluster role without DB
 	reloadClusterRoleConfig, err := r.reconcileClusterRoleWithoutDB(ctx, cluster)
 	if err != nil {

internal/management/controller/instance_startup.go

@@ -261,15 +261,6 @@ func (r *InstanceReconciler) verifyPgDataCoherenceForPrimary(ctx context.Context
 			}
 		}
 
-		// Change back the mode of the postgresql.auto.conf file
-		if !cluster.Spec.PostgresConfiguration.EnableAlterSystem {
-			err = r.instance.SetAlterSystemEnabled(cluster.Spec.PostgresConfiguration.EnableAlterSystem)
-			if err != nil {
-				contextLogger.Error(
-					err, "Error while changing mode of the postgresql.auto.conf file after pg_rewind, skipped")
-			}
-		}
-
 		// Now I can demote myself
 		return r.instance.Demote(ctx, cluster)
 	}