Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using postgresql.auto.conf for server configuration #2727

Closed
gbartolini opened this issue Sep 11, 2023 · 0 comments · Fixed by #2812
Closed

Stop using postgresql.auto.conf for server configuration #2727

gbartolini opened this issue Sep 11, 2023 · 0 comments · Fixed by #2812
Assignees
@gbartolini
Labels
enhancement 🪄 New feature or request good first issue Good for newcomers

Comments

@gbartolini
Copy link
Contributor

At the moment, CloudNativePG writes its own settings in the postgresql.auto.conf file directly. For example:

recovery_target_timeline = 'latest'
restore_command = '/controller/manager wal-restore --log-destination /controller/log/postgres.json %f %p'
primary_slot_name = '_cnpg_freddie_1_initdb'
primary_conninfo = 'host=freddie-rw user=streaming_replica port=5432 sslkey=/controller/certificates/streaming_replica.key sslcert=/controller/certificates/streaming_replica.crt sslrootcert=/controller/certificates/server-ca.crt application_name=freddie-1-initdb sslmode=verify-ca'

Use a separate file called override.conf for this purpose (feel free to change the name during the analysis if you find a better one). Related to #2725
@gbartolini gbartolini added enhancement 🪄 New feature or request good first issue Good for newcomers labels Sep 11, 2023
@gbartolini gbartolini self-assigned this Sep 11, 2023
gbartolini added a commit that referenced this issue Sep 11, 2023
@gbartolini
refactor: use override.conf instead of postgresql.auto.conf
9b22072 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes #2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
@gbartolini gbartolini mentioned this issue Sep 11, 2023
Closed
gbartolini added a commit that referenced this issue Sep 11, 2023
@gbartolini
refactor: use override.conf instead of postgresql.auto.conf
2a50378 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes #2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
gbartolini added a commit that referenced this issue Sep 11, 2023
@gbartolini
refactor: use override.conf instead of postgresql.auto.conf
59578f8 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes #2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
mnencia pushed a commit to EnterpriseDB/cloudnative-pg that referenced this issue Sep 14, 2023
@gbartolini @mnencia
refactor: use override.conf instead of postgresql.auto.conf
63bb923 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes cloudnative-pg#2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
@YanniHu1996 YanniHu1996 mentioned this issue Sep 19, 2023
Merged
litaocdl pushed a commit that referenced this issue Sep 19, 2023
@gbartolini @litaocdl
refactor: use override.conf instead of postgresql.auto.conf
5cb5bdf 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes #2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
litaocdl pushed a commit to EnterpriseDB/cloudnative-pg that referenced this issue Sep 19, 2023
@gbartolini @litaocdl
refactor: use override.conf instead of postgresql.auto.conf
4381f6d 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes cloudnative-pg#2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
litaocdl pushed a commit to EnterpriseDB/cloudnative-pg that referenced this issue Sep 21, 2023
@gbartolini @litaocdl
refactor: use override.conf instead of postgresql.auto.conf
b46e088 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes cloudnative-pg#2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
litaocdl pushed a commit to EnterpriseDB/cloudnative-pg that referenced this issue Sep 21, 2023
@gbartolini @litaocdl
refactor: use override.conf instead of postgresql.auto.conf
90e26fb 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes cloudnative-pg#2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
litaocdl pushed a commit to EnterpriseDB/cloudnative-pg that referenced this issue Sep 21, 2023
@gbartolini @litaocdl
refactor: use override.conf instead of postgresql.auto.conf
fbcf1f0 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes cloudnative-pg#2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
gbartolini added a commit to EnterpriseDB/cloudnative-pg that referenced this issue Sep 22, 2023
@gbartolini
refactor: use override.conf instead of postgresql.auto.conf
0afb494 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes cloudnative-pg#2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
litaocdl pushed a commit to EnterpriseDB/cloudnative-pg that referenced this issue Sep 25, 2023
@gbartolini @litaocdl
refactor: use override.conf instead of postgresql.auto.conf
744f17b 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes cloudnative-pg#2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
mnencia pushed a commit to EnterpriseDB/cloudnative-pg that referenced this issue Sep 26, 2023
@gbartolini @mnencia
refactor: use override.conf instead of postgresql.auto.conf
834ff08 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes cloudnative-pg#2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
mnencia pushed a commit to EnterpriseDB/cloudnative-pg that referenced this issue Sep 27, 2023
@gbartolini @mnencia
refactor: use override.conf instead of postgresql.auto.conf
8adafcd 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes cloudnative-pg#2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
mnencia pushed a commit to EnterpriseDB/cloudnative-pg that referenced this issue Sep 27, 2023
@gbartolini @mnencia
refactor: use override.conf instead of postgresql.auto.conf
9dec98e 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes cloudnative-pg#2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
mnencia pushed a commit to EnterpriseDB/cloudnative-pg that referenced this issue Sep 27, 2023
@gbartolini @mnencia
refactor: use override.conf instead of postgresql.auto.conf
328aac0 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes cloudnative-pg#2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
mnencia pushed a commit to EnterpriseDB/cloudnative-pg that referenced this issue Sep 29, 2023
@gbartolini @mnencia
refactor: use override.conf instead of postgresql.auto.conf
70b2e4a 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes cloudnative-pg#2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
litaocdl pushed a commit to EnterpriseDB/cloudnative-pg that referenced this issue Oct 7, 2023
@gbartolini @litaocdl
refactor: use override.conf instead of postgresql.auto.conf
6d12db7 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes cloudnative-pg#2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
leonardoce pushed a commit to EnterpriseDB/cloudnative-pg that referenced this issue Oct 19, 2023
@gbartolini @leonardoce
refactor: use override.conf instead of postgresql.auto.conf
a069613 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes cloudnative-pg#2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
leonardoce pushed a commit to EnterpriseDB/cloudnative-pg that referenced this issue Oct 19, 2023
@gbartolini @leonardoce
refactor: use override.conf instead of postgresql.auto.conf
8616d16 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes cloudnative-pg#2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
gbartolini added a commit to EnterpriseDB/cloudnative-pg that referenced this issue Oct 19, 2023
@gbartolini
refactor: use override.conf instead of postgresql.auto.conf
35a397d 
Up to now, CloudNativePG has been using the `postgresql.auto.conf`
to manage PostgreSQL GUCs that coordinate activities in a PostgreSQL
cluster in terms of HA and DR, primarily. Given that `postgresql.auto.conf`
is used directly by the `ALTER SYSTEM` command in PostgreSQL, we
should use a different file, called `override.conf` for the above
purposes.

Closes cloudnative-pg#2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
gbartolini added a commit that referenced this issue Oct 19, 2023
@YanniHu1996 @gbartolini
@litaocdl @armru @mnencia
feat: stop using postgresql.auto.conf to control Postgres (#2812)
4ec09e6 
CloudNativePG was writing its own settings in the `postgresql.auto.conf` file directly.
For example:

```
recovery_target_timeline = 'latest'
restore_command = 'XXXX'
primary_slot_name = 'XXXX'
primary_conninfo = 'XXXX'
```

We are now using a separate file called `override.conf`.

Closes #2727 

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com>
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Tao Li <tao.li@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
cnpg-bot pushed a commit that referenced this issue Oct 19, 2023
@YanniHu1996
feat: stop using postgresql.auto.conf to control Postgres (#2812)
f12b566 
CloudNativePG was writing its own settings in the `postgresql.auto.conf` file directly.
For example:

```
recovery_target_timeline = 'latest'
restore_command = 'XXXX'
primary_slot_name = 'XXXX'
primary_conninfo = 'XXXX'
```

We are now using a separate file called `override.conf`.

Closes #2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com>
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Tao Li <tao.li@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
(cherry picked from commit 4ec09e6)
cnpg-bot pushed a commit that referenced this issue Oct 19, 2023
@YanniHu1996
feat: stop using postgresql.auto.conf to control Postgres (#2812)
f3447e3 
CloudNativePG was writing its own settings in the `postgresql.auto.conf` file directly.
For example:

```
recovery_target_timeline = 'latest'
restore_command = 'XXXX'
primary_slot_name = 'XXXX'
primary_conninfo = 'XXXX'
```

We are now using a separate file called `override.conf`.

Closes #2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com>
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Tao Li <tao.li@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
(cherry picked from commit 4ec09e6)
cnpg-bot pushed a commit that referenced this issue Oct 19, 2023
@YanniHu1996
feat: stop using postgresql.auto.conf to control Postgres (#2812)
383cd85 
CloudNativePG was writing its own settings in the `postgresql.auto.conf` file directly.
For example:

```
recovery_target_timeline = 'latest'
restore_command = 'XXXX'
primary_slot_name = 'XXXX'
primary_conninfo = 'XXXX'
```

We are now using a separate file called `override.conf`.

Closes #2727

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com>
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Tao Li <tao.li@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
(cherry picked from commit 4ec09e6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbartolini gbartolini

Labels
enhancement 🪄 New feature or request good first issue Good for newcomers
Projects
CloudNativePG operator development
Status: Done
Milestone
No milestone
1 participant
@gbartolini