Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: kubectl-cnpg status --> Physical backups progress #4323

Closed
4 tasks done
smiyc opened this issue Apr 17, 2024 · 1 comment
Closed
4 tasks done

[Bug]: kubectl-cnpg status --> Physical backups progress #4323

smiyc opened this issue Apr 17, 2024 · 1 comment
Assignees
Labels
triage Pending triage

Comments

@smiyc
Copy link
Contributor

smiyc commented Apr 17, 2024

Is there an existing issue already for this bug?

  • I have searched for an existing issue, and could not find anything. I believe this is a new bug.

I have read the troubleshooting guide

  • I have read the troubleshooting guide and I think this is a new bug.

I am running a supported version of CloudNativePG

  • I have read the troubleshooting guide and I think this is a new bug.

Contact Details

smiyc@pm.me

Version

1.22.2

What version of Kubernetes are you using?

1.26

What is your Kubernetes environment?

Other

How did you install the operator?

YAML manifest

What happened?

The progress in the Physical backups section of kubectl-cnpg status is not correctly calculated

Physical backups
Name             Phase                     Started at                   Total  Transferred  Progress  Tablespaces
----             -----                     ----------                   -----  -----------  --------  -----------
keycloak-2-join  streaming database files  2024-04-17T12:59:48.939639Z  46 GB  38 GB        0.84%     0/1

according to 2d1c4db the progress is calculated BackupStreamed/BackupTotal

		progress := ""
		if bb.BackupTotal != 0 {
			progress = fmt.Sprintf("%.2f%%", float64(bb.BackupStreamed)/float64(bb.BackupTotal))
		}

imho it should be 100/BackupTotal*BackupStreamed

Cluster resource

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@smiyc smiyc added the triage Pending triage label Apr 17, 2024
@sxd
Copy link
Member

sxd commented May 20, 2024

This was already fixed on #4131

@sxd sxd closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Pending triage
Projects
None yet
Development

No branches or pull requests

3 participants