Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: each times PostgreSQL starts, we SIGHUP it two times to change the pg_ident file #4626

Closed
4 tasks done
leonardoce opened this issue May 21, 2024 · 0 comments · Fixed by #4648
Closed
4 tasks done

[Bug]: each times PostgreSQL starts, we SIGHUP it two times to change the pg_ident file #4626

leonardoce opened this issue May 21, 2024 · 0 comments · Fixed by #4648
Assignees
@gbartolini
Labels
triage Pending triage

Comments

@leonardoce
Copy link
Contributor

Is there an existing issue already for this bug?

  • I have searched for an existing issue, and could not find anything. I believe this is a new bug.

I have read the troubleshooting guide

  • I have read the troubleshooting guide and I think this is a new bug.

I am running a supported version of CloudNativePG

  • I have read the troubleshooting guide and I think this is a new bug.

Contact Details

leonardo.cecchi@enteprisedb.com

Version

1.23.1

What version of Kubernetes are you using?

1.30 (unsupported)

What is your Kubernetes environment?

Self-managed: kind (evaluation)

How did you install the operator?

YAML manifest

What happened?

Everytime the instance manager starts PostgreSQL, it will SIGHUP it two times to install two slightly different versions of the pg_ident file.
This is easily reproducible by fencing on and off an instance.

Cluster resource

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@leonardoce leonardoce added the triage Pending triage label May 21, 2024
@leonardoce leonardoce changed the title [Bug]: each times PostgreSQL starts, we SIGHUP it two times to change the pg_ident fiel [Bug]: each times PostgreSQL starts, we SIGHUP it two times to change the pg_ident file May 21, 2024
leonardoce added a commit to leonardoce/cloudnative-pg that referenced this issue May 23, 2024
@leonardoce
fix: avoid reloading ident map when not needed
90d1c22 
Before this patch, the instance manager could write the ident map using
two different formats even if the content was semantically the same.

This was triggering an unneeded configuration reload after the
postmaster was started up.

Fixes: cloudnative-pg#4626
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
leonardoce added a commit to leonardoce/cloudnative-pg that referenced this issue May 23, 2024
@leonardoce
fix: avoid reloading ident map when not needed
4a956d1 
Before this patch, the instance manager could write the ident map using
two different formats even if the content was semantically the same.

This was triggering an unneeded configuration reload after the
postmaster was started up.

Fixes: cloudnative-pg#4626

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
leonardoce added a commit to leonardoce/cloudnative-pg that referenced this issue May 23, 2024
@leonardoce
fix: avoid reloading ident map when not needed
8cedd54 
Before this patch, the instance manager could write the ident map using
two different formats even if the content was semantically the same.

This was triggering an unneeded configuration reload after the
postmaster was started up.

Fixes: cloudnative-pg#4626

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
@leonardoce leonardoce mentioned this issue May 23, 2024
Merged
mnencia pushed a commit to leonardoce/cloudnative-pg that referenced this issue May 24, 2024
@leonardoce @mnencia
fix: avoid reloading ident map when not needed
56a340e 
Before this patch, the instance manager could write the ident map using
two different formats even if the content was semantically the same.

This was triggering an unneeded configuration reload after the
postmaster was started up.

Fixes: cloudnative-pg#4626

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
mnencia pushed a commit to leonardoce/cloudnative-pg that referenced this issue May 24, 2024
@leonardoce @mnencia
fix: avoid reloading ident map when not needed
6435403 
Before this patch, the instance manager could write the ident map using
two different formats even if the content was semantically the same.

This was triggering an unneeded configuration reload after the
postmaster was started up.

Fixes: cloudnative-pg#4626

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
leonardoce added a commit to leonardoce/cloudnative-pg that referenced this issue May 27, 2024
@leonardoce
fix: avoid reloading ident map when not needed
e178818 
Before this patch, the instance manager could write the ident map using
two different formats even if the content was semantically the same.

This was triggering an unneeded configuration reload after the
postmaster was started up.

Fixes: cloudnative-pg#4626

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
leonardoce added a commit to leonardoce/cloudnative-pg that referenced this issue May 28, 2024
@leonardoce
fix: avoid reloading ident map when not needed
10655ac 
Before this patch, the instance manager could write the ident map using
two different formats even if the content was semantically the same.

This was triggering an unneeded configuration reload after the
postmaster was started up.

Fixes: cloudnative-pg#4626

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
leonardoce added a commit to leonardoce/cloudnative-pg that referenced this issue May 28, 2024
@leonardoce
fix: avoid reloading ident map when not needed
72d76a5 
Before this patch, the instance manager could write the ident map using
two different formats even if the content was semantically the same.

This was triggering an unneeded configuration reload after the
postmaster was started up.

Fixes: cloudnative-pg#4626

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
leonardoce added a commit that referenced this issue May 28, 2024
@leonardoce @mnencia @jsilvela
fix: avoid reloading ident map when not needed (#4648)
6b3039e 
Before this patch, the instance manager could write the ident map using
two different formats, even if the content was semantically the same.

This was triggering an unneeded configuration reload after the
postmaster was started up.

Fixes: #4626

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
cnpg-bot pushed a commit that referenced this issue May 28, 2024
@leonardoce
fix: avoid reloading ident map when not needed (#4648)
15bb420 
Before this patch, the instance manager could write the ident map using
two different formats, even if the content was semantically the same.

This was triggering an unneeded configuration reload after the
postmaster was started up.

Fixes: #4626

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
(cherry picked from commit 6b3039e)
cnpg-bot pushed a commit that referenced this issue May 28, 2024
@leonardoce
fix: avoid reloading ident map when not needed (#4648)
6ba667d 
Before this patch, the instance manager could write the ident map using
two different formats, even if the content was semantically the same.

This was triggering an unneeded configuration reload after the
postmaster was started up.

Fixes: #4626

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
(cherry picked from commit 6b3039e)
cnpg-bot pushed a commit that referenced this issue May 28, 2024
@leonardoce
fix: avoid reloading ident map when not needed (#4648)
e322761 
Before this patch, the instance manager could write the ident map using
two different formats, even if the content was semantically the same.

This was triggering an unneeded configuration reload after the
postmaster was started up.

Fixes: #4626

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
(cherry picked from commit 6b3039e)
dougkirkley pushed a commit to dougkirkley/cloudnative-pg that referenced this issue Jun 11, 2024
@leonardoce @mnencia @jsilvela
fix: avoid reloading ident map when not needed (cloudnative-pg#4648)
3c86e22 
Before this patch, the instance manager could write the ident map using
two different formats, even if the content was semantically the same.

This was triggering an unneeded configuration reload after the
postmaster was started up.

Fixes: cloudnative-pg#4626

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Douglass Kirkley <dkirkley@eitccorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbartolini gbartolini

Labels
triage Pending triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid reloading ident map when not needed leonardoce/cloudnative-pg
2 participants
@gbartolini @leonardoce