fix: avoid reloading ident map when not needed #4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
mnencia
reviewed
May 24, 2024
mnencia
approved these changes
May 24, 2024
jsilvela
approved these changes
May 27, 2024
leonardoce
force-pushed
the
sighup-ident
branch
2 times, most recently
from
4c504f1
to
50aef48
Compare
|
/ok-to-merge all green!!! |
Before this patch, the instance manager could write the ident map using two different formats even if the content was semantically the same. This was triggering an unneeded configuration reload after the postmaster was started up. Fixes: cloudnative-pg#4626 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
cnpg-bot
pushed a commit
that referenced
this pull request
May 28, 2024
Before this patch, the instance manager could write the ident map using two different formats, even if the content was semantically the same. This was triggering an unneeded configuration reload after the postmaster was started up. Fixes: #4626 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> (cherry picked from commit 6b3039e)
cnpg-bot
pushed a commit
that referenced
this pull request
May 28, 2024
Before this patch, the instance manager could write the ident map using two different formats, even if the content was semantically the same. This was triggering an unneeded configuration reload after the postmaster was started up. Fixes: #4626 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> (cherry picked from commit 6b3039e)
cnpg-bot
pushed a commit
that referenced
this pull request
May 28, 2024
Before this patch, the instance manager could write the ident map using two different formats, even if the content was semantically the same. This was triggering an unneeded configuration reload after the postmaster was started up. Fixes: #4626 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> (cherry picked from commit 6b3039e)
dougkirkley
pushed a commit
to dougkirkley/cloudnative-pg
that referenced
this pull request
Jun 11, 2024
Before this patch, the instance manager could write the ident map using two different formats, even if the content was semantically the same. This was triggering an unneeded configuration reload after the postmaster was started up. Fixes: cloudnative-pg#4626 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Douglass Kirkley <dkirkley@eitccorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, the instance manager could write the ident map using two different formats even if the content was semantically the same.
This was triggering an unneeded configuration reload after the postmaster was started up.
Fixes: #4626