fix: filter out replicas and jobs from nodeToClusters map #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsilvela
requested review from
leonardoce,
mnencia,
phisco,
sxd and
armru
as code owners
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
|
/test |
|
@jsilvela, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/3694659356 |
jsilvela
changed the title
sxd
approved these changes
Dec 14, 2022
mnencia
approved these changes
Dec 15, 2022
phisco
approved these changes
Dec 15, 2022
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
|
/ok-to-merge |
cnpg-bot
pushed a commit
that referenced
this pull request
Dec 16, 2022
We have found that using HasLabels and MatchingLabels in the same Kubernetes List call leads to only one of them being applied. See kubernetes-sigs/controller-runtime#2098 This patch fixes one occurrence of this double usage in the operator code, avoiding some unneeded reconciliation cycles. Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> (cherry picked from commit 2aaa31c)
sxd
pushed a commit
that referenced
this pull request
Dec 20, 2022
We have found that using HasLabels and MatchingLabels in the same Kubernetes List call leads to only one of them being applied. See kubernetes-sigs/controller-runtime#2098 This patch fixes one occurrence of this double usage in the operator code, avoiding some unneeded reconciliation cycles. Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
sxd
pushed a commit
that referenced
this pull request
Dec 20, 2022
We have found that using HasLabels and MatchingLabels in the same Kubernetes List call leads to only one of them being applied. See kubernetes-sigs/controller-runtime#2098 This patch fixes one occurrence of this double usage in the operator code, avoiding some unneeded reconciliation cycles. Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
mnencia
pushed a commit
that referenced
this pull request
Dec 29, 2022
We have found that using HasLabels and MatchingLabels in the same Kubernetes List call leads to only one of them being applied. See kubernetes-sigs/controller-runtime#2098 This patch fixes one occurrence of this double usage in the operator code, avoiding some unneeded reconciliation cycles. Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the filtering applied to map nodes to CNPG clusters when a node
is cordoned, to create reconciliations only from primary instance pods
Closes #1193
Signed-off-by: Jaime Silvela jaime.silvela@enterprisedb.com