New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grafana-dashboard.json #1916
Conversation
❗ By default, the pull request is configured to backport to all release branches.
|
744a2d8
to
c5532ee
Compare
c5532ee
to
75276dd
Compare
Sorry for the delay. Been deploying this locally. "datasource": {
"type": "prometheus",
"uid": "${DS_PROMETHEUS}"
} These will not work properly with the Grafana as we deploy from the quickstart, using the kube-prometheus-stack. |
Since the JSON file you generated, in particular, you took from a grafana deployed with a different mechanism, I think there is value in keeping it as-is. |
On the dashboard itself, the amount of work and polish is ... 👏 bravo. |
75276dd
to
29c2aed
Compare
With Itay's latest commit, the dashboard works out of the box if following the |
@itay-grudev fallowing @jsilvela advice, I think we should add the disclaimer into the quickstart with this PR adding that some features may fails because they need a really new/early version of Grafana. I'm also adding my self as a reviewer to this PR because I really want to try ti! :D |
@sxd and @itay-grudev ill happily test/review what I can. Already have the dashboard running :) |
@sxd I discussed offline with @jsilvela that the alpha metrics are enabled by default on Prometheus. I think it's a limitation of KinD that the volume data is not reported. I've tested it on AWS EKS and Digital Ocean and there it works fine. I still need to add the change @benoitschipper proposed. |
@itay-grudev I've added a warning message that will help users to understand why the graphs doesn't have data, can you review it please! I understand that those are limited in KinD, but lots of users use KinD for testing and at least we need to be nice and put the warning message |
Ill check/review it by testing it as soon as you have added the regex proposal so I can confirm if it works. |
ae65888
to
4df2bb3
Compare
@benoitschipper Done. Test if it works for you now. |
Will do! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itay-grudev I loaded the Dashboard and went through all the graphs on a live cluster in two seperate clusters. All worked without me making any changes (only the name). Works like a charm!
141aa3a
to
4822f15
Compare
Signed-off-by: Itay Grudev <igrudev@clustermarket.com>
Signed-off-by: Itay Grudev <igrudev@clustermarket.com>
4822f15
to
d1e7086
Compare
* Base backup and last archived WAL information * Total CPU and memory usage across all nodes * An Alerts section * Last failover/switchover time * Cluster PostgreSQL version * Transactions per second * Volume usage and total database size * Replication/Write/Flush/Replay lag * Added instance zone * Displaying the full PostgreSQL version * Bug Fix: When there are redundant `kube-state-metrics` instances there are duplicate status gauges * Bug Fix: Max Connections not displaying a progress bar in the gauge due to missing `min` and `max` values. * Transposed configuration section * Added volume space and inode usage gauges. * Fixed tooltips and set shared crosshairs of all graphs. * Bug Fix: Cluster variable query picking up any metric ending with cluster --------- Signed-off-by: Itay Grudev <igrudev@clustermarket.com> (cherry picked from commit aea4365)
* Base backup and last archived WAL information * Total CPU and memory usage across all nodes * An Alerts section * Last failover/switchover time * Cluster PostgreSQL version * Transactions per second * Volume usage and total database size * Replication/Write/Flush/Replay lag * Added instance zone * Displaying the full PostgreSQL version * Bug Fix: When there are redundant `kube-state-metrics` instances there are duplicate status gauges * Bug Fix: Max Connections not displaying a progress bar in the gauge due to missing `min` and `max` values. * Transposed configuration section * Added volume space and inode usage gauges. * Fixed tooltips and set shared crosshairs of all graphs. * Bug Fix: Cluster variable query picking up any metric ending with cluster --------- Signed-off-by: Itay Grudev <igrudev@clustermarket.com> (cherry picked from commit aea4365)
* Base backup and last archived WAL information * Total CPU and memory usage across all nodes * An Alerts section * Last failover/switchover time * Cluster PostgreSQL version * Transactions per second * Volume usage and total database size * Replication/Write/Flush/Replay lag * Added instance zone * Displaying the full PostgreSQL version * Bug Fix: When there are redundant `kube-state-metrics` instances there are duplicate status gauges * Bug Fix: Max Connections not displaying a progress bar in the gauge due to missing `min` and `max` values. * Transposed configuration section * Added volume space and inode usage gauges. * Fixed tooltips and set shared crosshairs of all graphs. * Bug Fix: Cluster variable query picking up any metric ending with cluster --------- Signed-off-by: Itay Grudev <igrudev@clustermarket.com> (cherry picked from commit aea4365)
New Cluster Overview
A new cluster overview section at the top that features:
Server Health
kube-state-metrics
instances there are duplicate status gaugesmin
andmax
values.Before:
After:
Configuration
The configuration parameters are transposed such that every row now contains a parameter, while every column contains the parameter setting across individual database instances. This makes it much easier to scroll through settings.
Before:
After:
New Storage & IO Space and Inode Usage metrics
Added volume space and inode usage gauges.
Accumulated Tuple/IO graph to make the data more comprehensible
Before:
After:
General