feat: Add support for logical replication slots with HA (#1962) #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjuls
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco,
sxd and
armru
as code owners
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
…pg#1962) Signed-off-by: Jakob Schultz-Falk <sjulsbe@gmail.com>
Don't actually think the PR is relevant anymore since pg_failover_slots has become a managed extension in CloudNativePG. https://cloudnative-pg.io/documentation/1.20/postgresql_conf/#enabling-pg_failover_slots I'll close this PR. |
|
❗ By default, the pull request is configured to backport to all release branches.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support for cloning logical replication slots from primary to standbys and advancing the LSN in the same cadence as the current physical replication slots.
The cloning is performed by reading the logical replication slot state off the disk of the primary through the SQL layer, then restarting the standby instance to pick up the new logical replication slot. From PostgreSQL 16 it should be possible to create the logical replication slots directly through SQL, which is also supported in the PR.
The HA logical replication is an extension of the HA physical replication slots, and is therefore enabled through the
.spec.replicationSlots.highAvailability.enabledproperty in the Cluster CRD.Also in the PR;
Closes #1962