feat: add TopologySpreadConstraints #2202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armru
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
sxd
as code owners
|
/test limit=local |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
adding risk label, we should consider where to backport this feat |
|
/test |
1 similar comment
|
/test |
|
@leonardoce, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/5179199970 |
litaocdl
approved these changes
Jun 8, 2023
|
/test |
|
@jsilvela, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/5221298277 |
jsilvela
approved these changes
Jun 9, 2023
|
/ok-to-merge |
Closes #2192 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
sxd
approved these changes
Jun 10, 2023
cnpg-bot
pushed a commit
that referenced
this pull request
Jun 10, 2023
Since Kubernetes 1.19 the Topology Constraint went to GA, meaning that we can start using it, but this wasn't needed before, now with the latest version 1.26 and 1.27 many things were improved and now we can implement Topology Constraints. Some features may not work since they're available only on 1.26 or above, for any reference please read https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/ to get more information. Closes #2192 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> (cherry picked from commit 50601b0)
sxd
pushed a commit
that referenced
this pull request
Jun 10, 2023
Since Kubernetes 1.19 the Topology Constraint went to GA, meaning that we can start using it, but this wasn't needed before, now with the latest version 1.26 and 1.27 many things were improved and now we can implement Topology Constraints. Some features may not work since they're available only on 1.26 or above, for any reference please read https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/ to get more information. Closes #2192 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
sxd
pushed a commit
that referenced
this pull request
Jun 10, 2023
Since Kubernetes 1.19 the Topology Constraint went to GA, meaning that we can start using it, but this wasn't needed before, now with the latest version 1.26 and 1.27 many things were improved and now we can implement Topology Constraints. Some features may not work since they're available only on 1.26 or above, for any reference please read https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/ to get more information. Closes #2192 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2192