feat: add schemaOnly to the import section #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armru
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
sxd
as code owners
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
/test limit=local |
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/5212362117 |
gbartolini
approved these changes
Jun 8, 2023
jlong49
approved these changes
Jun 8, 2023
litaocdl
approved these changes
Jun 9, 2023
Closes #2228 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
|
/test depth=push test_level=4 feature_type=importing-databases |
|
@sxd, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/5220778617 |
cnpg-bot
pushed a commit
that referenced
this pull request
Jun 9, 2023
The import feature was previously importing everything, schema and data, with this new feature we will be able to select only schema or schema and data. The way is doing this it's using the `section` feature from `pg_dump` and `pg_restore` commands, we select which section we want to dump/restore, for a full dump and restore we use `pre-data`, `data` and `post-data` sections, while to import only the schema the section `pre-data` and `post-data` is used. Closes #2228 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com> (cherry picked from commit ad0fdb2)
cnpg-bot
pushed a commit
that referenced
this pull request
Jun 9, 2023
The import feature was previously importing everything, schema and data, with this new feature we will be able to select only schema or schema and data. The way is doing this it's using the `section` feature from `pg_dump` and `pg_restore` commands, we select which section we want to dump/restore, for a full dump and restore we use `pre-data`, `data` and `post-data` sections, while to import only the schema the section `pre-data` and `post-data` is used. Closes #2228 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com> (cherry picked from commit ad0fdb2)
cnpg-bot
pushed a commit
that referenced
this pull request
Jun 9, 2023
The import feature was previously importing everything, schema and data, with this new feature we will be able to select only schema or schema and data. The way is doing this it's using the `section` feature from `pg_dump` and `pg_restore` commands, we select which section we want to dump/restore, for a full dump and restore we use `pre-data`, `data` and `post-data` sections, while to import only the schema the section `pre-data` and `post-data` is used. Closes #2228 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com> (cherry picked from commit ad0fdb2)
armru
added a commit
that referenced
this pull request
Jun 9, 2023
The import feature was previously importing everything, schema and data, with this new feature we will be able to select only schema or schema and data. The way is doing this it's using the `section` feature from `pg_dump` and `pg_restore` commands, we select which section we want to dump/restore, for a full dump and restore we use `pre-data`, `data` and `post-data` sections, while to import only the schema the section `pre-data` and `post-data` is used. Closes #2228 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2228