Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: avoid using PGPASSFILE environment variable #3522

Merged
merged 2 commits into from Dec 12, 2023
Merged

chore: avoid using PGPASSFILE environment variable #3522

merged 2 commits into from Dec 12, 2023

Conversation

leonardoce
Copy link
Contributor

@leonardoce leonardoce commented Dec 11, 2023 •
edited

We don't need to set the PGPASSFILE environment variable anymore since jackc/pgx is correctly handling the passfile connection string option.

This patch removes the code doing that.

See also #2386

@github-actions github-actions bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.20 release-1.21 labels Dec 11, 2023
@github-actions GitHub Actions
Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@github-actions GitHub Actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@leonardoce
Copy link
Contributor Author

E2e tests run: https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/7168423390

@github-actions GitHub Actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@gbartolini
Copy link
Contributor

I love this!

leonardoce and others added 2 commits December 12, 2023 11:13
@leonardoce @litaocdl
chore: avoid using PGPASSFILE environment variable
d0dd97f 
We don't need to set the PGPASSFILE environment variable anymore since
jackc/pgx is correctly handling the `passfile` connection string option.

This patch removes the code doing that.

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
@armru @litaocdl
chore: clarify doc
ce81f1e 
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@github-actions GitHub Actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@litaocdl
Copy link
Contributor

/test limit=local

@github-actions GitHub Actions
Copy link
Contributor

@litaocdl, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/7176484665

@litaocdl
Copy link
Contributor

/ok-to-merge

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Dec 12, 2023
@github-actions GitHub Actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@litaocdl litaocdl merged commit d6e427b into main Dec 12, 2023
29 of 32 checks passed
@litaocdl litaocdl deleted the dev/passfile branch December 12, 2023 06:11
cnpg-bot pushed a commit that referenced this pull request Dec 12, 2023
@leonardoce
chore: avoid using PGPASSFILE environment variable (#3522)
11d0c33 
This patch removed the PGPASSFILE environment variable since
jackc/pgx is correctly handling the `passfile` connection string option.

See also #2386

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit d6e427b)
cnpg-bot pushed a commit that referenced this pull request Dec 12, 2023
@leonardoce
chore: avoid using PGPASSFILE environment variable (#3522)
d33a704 
This patch removed the PGPASSFILE environment variable since
jackc/pgx is correctly handling the `passfile` connection string option.

See also #2386

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit d6e427b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbartolini gbartolini gbartolini approved these changes

@litaocdl litaocdl litaocdl approved these changes

@armru armru armru approved these changes

@fcanovai fcanovai Awaiting requested review from fcanovai

@mnencia mnencia Awaiting requested review from mnencia

@phisco phisco Awaiting requested review from phisco

@sxd sxd Awaiting requested review from sxd

Assignees
No one assigned
Labels
backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged release-1.20 release-1.21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@leonardoce @gbartolini @litaocdl @armru @cnpg-bot