fix: disable WAL archiving during import bootstrap #3743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbartolini
requested review from
fcanovai,
leonardoce,
mnencia,
phisco,
sxd and
armru
as code owners
github-actions
bot
added
the
backport-requested ◀️
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
❗ By default, the pull request is configured to backport to all release branches.
|
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
E2E test on EDB fork https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/7697496524 |
armru
approved these changes
Jan 29, 2024
gbartolini
changed the title
|
Rerun E2E tests after fixing wal senders GUC. See https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/7699971017 |
|
Run E2E tests on EDB account: https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/7709440784 |
mnencia
approved these changes
Jan 30, 2024
When using the import facility of the initdb bootstrap method in a job, optimize the PostgreSQL instance for the sole duration of the job, by setting the following GUCs: - `archive_mode` to `off` - `fsync` to `off` - `full_page_writes` to `off` - `wal_level` to `minimal` Then, restore the configuration and invoke `initdb --sync-only` before the end of the import job. Closes #3741 Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
|
/ok-to-merge |
cnpg-bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
When using the import facility of the initdb bootstrap method in a job, optimize the PostgreSQL instance for the sole duration of the job by setting the following GUCs: - `archive_mode` to `off` - `fsync` to `off` - `full_page_writes` to `off` - `max_wal_senders` to `0` - `wal_level` to `minimal` Then, restore the configuration and invoke `initdb --sync-only` before the end of the import job. This avoids unnecessary and systematic piling of WAL files during any import job. Closes #3741 Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 9e58cbd)
cnpg-bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
When using the import facility of the initdb bootstrap method in a job, optimize the PostgreSQL instance for the sole duration of the job by setting the following GUCs: - `archive_mode` to `off` - `fsync` to `off` - `full_page_writes` to `off` - `max_wal_senders` to `0` - `wal_level` to `minimal` Then, restore the configuration and invoke `initdb --sync-only` before the end of the import job. This avoids unnecessary and systematic piling of WAL files during any import job. Closes #3741 Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 9e58cbd)
cnpg-bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
When using the import facility of the initdb bootstrap method in a job, optimize the PostgreSQL instance for the sole duration of the job by setting the following GUCs: - `archive_mode` to `off` - `fsync` to `off` - `full_page_writes` to `off` - `max_wal_senders` to `0` - `wal_level` to `minimal` Then, restore the configuration and invoke `initdb --sync-only` before the end of the import job. This avoids unnecessary and systematic piling of WAL files during any import job. Closes #3741 Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 9e58cbd)
armru
added a commit
that referenced
this pull request
Feb 1, 2024
When using the import facility of the initdb bootstrap method in a job, optimize the PostgreSQL instance for the sole duration of the job by setting the following GUCs: - `archive_mode` to `off` - `fsync` to `off` - `full_page_writes` to `off` - `max_wal_senders` to `0` - `wal_level` to `minimal` Then, restore the configuration and invoke `initdb --sync-only` before the end of the import job. This avoids unnecessary and systematic piling of WAL files during any import job. Closes #3741 Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the import facility of the initdb bootstrap method in a job, optimize the PostgreSQL instance for the sole duration of the job, by setting the following GUCs:
archive_modetoofffsynctoofffull_page_writestooffmax_wal_sendersto0wal_leveltominimalThen, restore the configuration and invoke
initdb --sync-onlybefore the end of the import job.This avoids unnecessary and systematic piling of WAL files during any import job.
Closes #3741