Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(olm): use Role instead of ClusterRole for operator permissions #3855

Merged
merged 1 commit into from Feb 27, 2024

Conversation

sxd
Copy link
Member

@sxd sxd commented Feb 21, 2024

Downgrade operator permissions in OLM deployments from Cluster level (ClusterRole and ClusterRoleBinding) to the namespace level (Role and RoleBinding).

Closes #3854

@github-actions github-actions bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.21 release-1.22 labels Feb 21, 2024
Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@sxd sxd marked this pull request as ready for review February 22, 2024 09:41
@sxd sxd force-pushed the dev/3854 branch 2 times, most recently from a306645 to 9c1cae2 Compare February 22, 2024 10:49
@mnencia
Copy link
Member

mnencia commented Feb 27, 2024

/ok-to-merge

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Feb 27, 2024
This will fix the issue of having clusterPermissions instead of permissions
in the OLM deployment allowing properly handling the permissions in a cluster
with the operator installed per namespace

Closes #3854

Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
@gbartolini gbartolini changed the title fix: make the OLM cluster permissions into role permissions fix(olm): use Role instead of ClusterRole for operator permissions Feb 27, 2024
@mnencia mnencia merged commit bbbcf59 into main Feb 27, 2024
32 checks passed
@mnencia mnencia deleted the dev/3854 branch February 27, 2024 14:41
cnpg-bot pushed a commit that referenced this pull request Feb 27, 2024
#3855)

This will fix the issue of having clusterPermissions instead of
permissions in the OLM deployment, allowing proper handling of the
permissions in a cluster with the operator installed per namespace.

Closes #3854

Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
(cherry picked from commit bbbcf59)
cnpg-bot pushed a commit that referenced this pull request Feb 27, 2024
#3855)

This will fix the issue of having clusterPermissions instead of
permissions in the OLM deployment, allowing proper handling of the
permissions in a cluster with the operator installed per namespace.

Closes #3854

Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
(cherry picked from commit bbbcf59)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged release-1.21 release-1.22
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: OLM Installation is using Cluster permissions instead of Role permissions
5 participants