New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(olm): use Role
instead of ClusterRole
for operator permissions
#3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-requested ◀️
This pull request should be backported to all supported releases
release-1.21
release-1.22
labels
Feb 21, 2024
❗ By default, the pull request is configured to backport to all release branches.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
sxd
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
armru
as code owners
February 22, 2024 09:41
sxd
force-pushed
the
dev/3854
branch
2 times, most recently
from
February 22, 2024 10:49
a306645
to
9c1cae2
Compare
NiccoloFei
approved these changes
Feb 22, 2024
litaocdl
approved these changes
Feb 23, 2024
mnencia
approved these changes
Feb 27, 2024
/ok-to-merge |
This will fix the issue of having clusterPermissions instead of permissions in the OLM deployment allowing properly handling the permissions in a cluster with the operator installed per namespace Closes #3854 Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
gbartolini
changed the title
fix: make the OLM cluster permissions into role permissions
fix(olm): use Feb 27, 2024
Role
instead of ClusterRole
for operator permissions
cnpg-bot
pushed a commit
that referenced
this pull request
Feb 27, 2024
#3855) This will fix the issue of having clusterPermissions instead of permissions in the OLM deployment, allowing proper handling of the permissions in a cluster with the operator installed per namespace. Closes #3854 Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com> (cherry picked from commit bbbcf59)
cnpg-bot
pushed a commit
that referenced
this pull request
Feb 27, 2024
#3855) This will fix the issue of having clusterPermissions instead of permissions in the OLM deployment, allowing proper handling of the permissions in a cluster with the operator installed per namespace. Closes #3854 Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com> (cherry picked from commit bbbcf59)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-requested ◀️
This pull request should be backported to all supported releases
ok to merge 👌
This PR can be merged
release-1.21
release-1.22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downgrade operator permissions in OLM deployments from Cluster level (
ClusterRole
andClusterRoleBinding
) to the namespace level (Role
andRoleBinding
).Closes #3854