feat: annotation to disable WAL archiving #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
leonardoce
force-pushed
the
dev/archive-mode-bis
branch
from
3700c5f
to
a5a5c45
Compare
leonardoce
requested review from
fcanovai,
gbartolini,
mnencia,
phisco,
sxd and
armru
as code owners
|
/test limit=local |
|
@leonardoce, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/8223295982 |
This was referenced Mar 10, 2024
gbartolini
changed the title
|
I have been able to disable WAL archiving and reduce WAL footprint with the following example: apiVersion: postgresql.cnpg.io/v1
kind: Cluster
metadata:
name: cluster-example
annotations:
cnpg.io/skipWalArchiving: "enabled"
spec:
instances: 1
storage:
size: 1Gi
postgresql:
parameters:
wal_level: minimal
max_wal_senders: "0" |
gbartolini
approved these changes
Mar 10, 2024
gbartolini
force-pushed
the
dev/archive-mode-bis
branch
from
6be025d
to
2950bef
Compare
|
/test limit=local |
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/8233800341 |
armru
approved these changes
Mar 11, 2024
|
/ok-to-merge |
armru
force-pushed
the
dev/archive-mode-bis
branch
from
23a8287
to
176c4c6
Compare
gbartolini
force-pushed
the
dev/archive-mode-bis
branch
from
176c4c6
to
c577985
Compare
gbartolini
changed the title
Closes: cloudnative-pg#3774 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@gmail.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@gmail.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@gmail.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enteprisedb.com> Signed-off-by: Leonardo Cecchi <leonardo.cecchi@gmail.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@gmail.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
gbartolini
force-pushed
the
dev/archive-mode-bis
branch
from
c577985
to
0e950de
Compare
cnpg-bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
Introduce the `cnpg.io/skipWalArchiving` annotation to disable WAL archiving when set to `enabled`. Closes: #3774 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@gmail.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enteprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 852ee34)
mnencia
pushed a commit
that referenced
this pull request
Mar 11, 2024
Introduce the `cnpg.io/skipWalArchiving` annotation to disable WAL archiving when set to `enabled`. Closes: #3774 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@gmail.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enteprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 852ee34)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the
cnpg.io/skipWalArchivingannotation to disable WAL archiving when set toenabled.Closes: #3774