fix: instance manager stuck if PostgreSQL doesn't start #4434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardoce
requested review from
fcanovai,
gbartolini,
mnencia,
phisco,
sxd and
armru
as code owners
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
jsilvela
reviewed
May 3, 2024
leonardoce
force-pushed
the
dev/recalcitrant-pg
branch
from
d8a2b52
to
16aaeb9
Compare
|
/test limit=local |
|
@leonardoce, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/8941773728 |
|
E2e tests are all green! |
armru
approved these changes
May 8, 2024
leonardoce
force-pushed
the
dev/recalcitrant-pg
branch
from
ba2c24a
to
6f8eb92
Compare
|
I think the concurrency in this code is difficult to understand correctly. I would like to have some comments to help understanding it. |
mnencia
approved these changes
May 9, 2024
If a primary PostgreSQL instance fails to start after being stopped, the instance manager is indefinitely waiting for it to start running the configuration queries. This patch creates a separate context for each postmaster process and runs the configuration queries in a parallel goroutine, canceling it as soon as the postmaster finishes. Fixes: cloudnative-pg#4433 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enteprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enteprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
mnencia
force-pushed
the
dev/recalcitrant-pg
branch
from
45ee97f
to
ef4c4fe
Compare
fcanovai
approved these changes
May 9, 2024
cnpg-bot
pushed a commit
that referenced
this pull request
May 9, 2024
If a primary PostgreSQL instance fails to start after being stopped, the instance manager is indefinitely waiting for it to start running the configuration queries. This patch creates a separate context for each postmaster process and runs the configuration queries in a parallel goroutine, canceling it as soon as the postmaster finishes. Fixes: #4433 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enteprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enteprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 473e5e7)
cnpg-bot
pushed a commit
that referenced
this pull request
May 9, 2024
If a primary PostgreSQL instance fails to start after being stopped, the instance manager is indefinitely waiting for it to start running the configuration queries. This patch creates a separate context for each postmaster process and runs the configuration queries in a parallel goroutine, canceling it as soon as the postmaster finishes. Fixes: #4433 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enteprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enteprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 473e5e7)
cnpg-bot
pushed a commit
that referenced
this pull request
May 9, 2024
If a primary PostgreSQL instance fails to start after being stopped, the instance manager is indefinitely waiting for it to start running the configuration queries. This patch creates a separate context for each postmaster process and runs the configuration queries in a parallel goroutine, canceling it as soon as the postmaster finishes. Fixes: #4433 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enteprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enteprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 473e5e7)
dougkirkley
pushed a commit
to dougkirkley/cloudnative-pg
that referenced
this pull request
Jun 11, 2024
…pg#4434) If a primary PostgreSQL instance fails to start after being stopped, the instance manager is indefinitely waiting for it to start running the configuration queries. This patch creates a separate context for each postmaster process and runs the configuration queries in a parallel goroutine, canceling it as soon as the postmaster finishes. Fixes: cloudnative-pg#4433 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enteprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enteprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Douglass Kirkley <dkirkley@eitccorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a primary PostgreSQL instance fails to start after being stopped, the instance manager is indefinitely waiting for it to start running the configuration queries.
This patch creates a separate context for each postmaster process and runs the configuration queries in a parallel goroutine, canceling it as soon as the postmaster finishes.
Fixes: #4433