fix: avoid shutting down the instance manager if it is not needed #4670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardoce
changed the title
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
sxd
approved these changes
May 24, 2024
mnencia
approved these changes
May 24, 2024
jsilvela
approved these changes
May 24, 2024
leonardoce
force-pushed
the
goodbye-instance-manager
branch
from
8bd171a
to
4258541
Compare
If we restarted PostgreSQL, but we don't manage to connect to it, we should proceed with the shutdown logic of the instance manager instead of quitting immediately with exit code 1. This is specially important when PG shut down because of missing disk space and when PG is up but trying to reach a consistent state. Closes: cloudnative-pg#4669 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
leonardoce
force-pushed
the
goodbye-instance-manager
branch
from
4258541
to
1c15c22
Compare
|
/ok-to-merge tests are fine |
cnpg-bot
pushed a commit
that referenced
this pull request
May 28, 2024
) If we restart PostgreSQL but don't manage to connect to it, we should proceed with the instance manager's shutdown logic instead of quitting immediately with exit code 1. This is especially important when PG shuts down because of missing disk space and when PG is up but trying to reach a consistent state. Closes: #4063 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 99b1ba4)
cnpg-bot
pushed a commit
that referenced
this pull request
May 28, 2024
) If we restart PostgreSQL but don't manage to connect to it, we should proceed with the instance manager's shutdown logic instead of quitting immediately with exit code 1. This is especially important when PG shuts down because of missing disk space and when PG is up but trying to reach a consistent state. Closes: #4063 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 99b1ba4)
cnpg-bot
pushed a commit
that referenced
this pull request
May 28, 2024
) If we restart PostgreSQL but don't manage to connect to it, we should proceed with the instance manager's shutdown logic instead of quitting immediately with exit code 1. This is especially important when PG shuts down because of missing disk space and when PG is up but trying to reach a consistent state. Closes: #4063 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 99b1ba4)
|
The issue linked in the PR description is wrong. This should have closed #4669. |
4 tasks
dougkirkley
pushed a commit
to dougkirkley/cloudnative-pg
that referenced
this pull request
Jun 11, 2024
…oudnative-pg#4670) If we restart PostgreSQL but don't manage to connect to it, we should proceed with the instance manager's shutdown logic instead of quitting immediately with exit code 1. This is especially important when PG shuts down because of missing disk space and when PG is up but trying to reach a consistent state. Closes: cloudnative-pg#4063 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Douglass Kirkley <dkirkley@eitccorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we restart PostgreSQL but don't manage to connect to it, we should proceed with the instance manager's shutdown logic instead of quitting immediately with exit code 1.
This is especially important when PG shuts down because of missing disk space and when PG is up but trying to reach a consistent state.
Closes: #4063