feat: stop requiring namespace object permissions #4753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
mnencia
force-pushed
the
dev/no-namespace
branch
2 times, most recently
from
3e5f824
to
e4e84a4
Compare
|
This PR requires #4735 to be merged first. |
sxd
approved these changes
Jun 3, 2024
leonardoce
force-pushed
the
dev/no-namespace
branch
from
b9b5f1e
to
d202f59
Compare
Remove the namespace deletion check at the start of the reconciliation cycle and the permissions to read namespace definitions. Closes #4752 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
mnencia
changed the title
leonardoce
approved these changes
Jun 3, 2024
|
/test tl=4 l=local d=main |
|
@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/9353473336 |
|
/ok-to-merge tests are fine |
dougkirkley
pushed a commit
to dougkirkley/cloudnative-pg
that referenced
this pull request
Jun 11, 2024
Remove the namespace deletion check at the start of the reconciliation cycle and the permissions to read namespace definitions. Closes cloudnative-pg#4752 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Douglass Kirkley <dkirkley@eitccorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the namespace deletion check at the start of the reconciliation
cycle and the permissions to read namespace definitions.
Closes #4752