fix: ensure HA slots don't hold xmin #4811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
|
Tests running on EDB fork https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/9400362878 |
mnencia
changed the title
|
/ok-to-merge E2E tests are green |
jsilvela
reviewed
Jun 7, 2024
jsilvela
approved these changes
Jun 7, 2024
Closes #4802 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
armru
approved these changes
Jun 10, 2024
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
cnpg-bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
When `hot_standby_feedback` is enabled, an inactive replication slot with `xmin` or `catalog_xmin` set to `NOT NULL`, could prevent the autovacuum on the primary from cleaning the old tuples. This issue may occur when a former primary rejoins the cluster after a switchover. This patch resolves the issue by recreating any HA replication slot on a standby instance if it has `xmin` or `catalog_xmin` set. Closes #4802 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit d932383)
mnencia
added a commit
that referenced
this pull request
Jun 11, 2024
When `hot_standby_feedback` is enabled, an inactive replication slot with `xmin` or `catalog_xmin` set to `NOT NULL`, could prevent the autovacuum on the primary from cleaning the old tuples. This issue may occur when a former primary rejoins the cluster after a switchover. This patch resolves the issue by recreating any HA replication slot on a standby instance if it has `xmin` or `catalog_xmin` set. Closes #4802 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit d932383)
mnencia
added a commit
that referenced
this pull request
Jun 11, 2024
When `hot_standby_feedback` is enabled, an inactive replication slot with `xmin` or `catalog_xmin` set to `NOT NULL`, could prevent the autovacuum on the primary from cleaning the old tuples. This issue may occur when a former primary rejoins the cluster after a switchover. This patch resolves the issue by recreating any HA replication slot on a standby instance if it has `xmin` or `catalog_xmin` set. Closes #4802 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit d932383)
dougkirkley
pushed a commit
to dougkirkley/cloudnative-pg
that referenced
this pull request
Jun 11, 2024
When `hot_standby_feedback` is enabled, an inactive replication slot with `xmin` or `catalog_xmin` set to `NOT NULL`, could prevent the autovacuum on the primary from cleaning the old tuples. This issue may occur when a former primary rejoins the cluster after a switchover. This patch resolves the issue by recreating any HA replication slot on a standby instance if it has `xmin` or `catalog_xmin` set. Closes cloudnative-pg#4802 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Douglass Kirkley <dkirkley@eitccorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
hot_standby_feedbackis enabled, an inactive replication slotwith
xminorcatalog_xminset to not NULL, could prevent theautovacuum on the primary from cleaning the old tuples.
This issue may occur when a former primary rejoins the cluster after
a switchover.
This patch resolves the issue by recreating any HA replication slot on
a standby instance if it has
xminorcatalog_xminset.Closes #4802