chore: prevents to bootstrapping a new cluster with a non-empty object store #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxd
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia and
phisco
as code owners
|
/test |
|
@sxd, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/2259718438 |
jsilvela
approved these changes
May 4, 2022
jlong49
approved these changes
May 6, 2022
jlong49
force-pushed
the
dev/cnpg-61
branch
3 times, most recently
from
0ea4dc3
to
b4b4508
Compare
mnencia
approved these changes
May 10, 2022
…t store The idea behind this patch it's to prevent any cluster boostrapping if case the target ObjectStore it's already used by another backup or it's not empty at all, thuse, we can prevent the overwrite of clusters backups and misunderstanding in the PostgreSQL timeline when trying to recover a pod. Closes #61 Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this patch it's to prevent any cluster bootstrapping
if case the target Object Store it's already used by another backup
or it's not empty at all, thus, we can prevent the overwrite of
clusters backups and misunderstanding in the PostgreSQL timeline
when trying to recover a pod.
Closes #61
Signed-off-by: Jonathan Gonzalez V jonathan.gonzalez@enterprisedb.com