Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Side Completion doesn't work #48

Open
Stono opened this issue Jan 14, 2018 · 12 comments
Open

Server Side Completion doesn't work #48

Stono opened this issue Jan 14, 2018 · 12 comments

Comments

@Stono
Copy link

Stono commented Jan 14, 2018

As per the title really, nothing pops up to be tabbed.
Version 0.0.23

@daikeren
Copy link

I've encountered this problem too. I'll try to find the cause and see if I could send a PR.

@murali-reddy Am I correct that I should look at https://github.com/cloudnativelabs/kube-shell/blob/master/kubeshell/parser.py to try to figure out how to do server side completion?

Thanks

@murali-reddy
Copy link
Member

@daikeren not sure what execatly is the problem. If you can share the error or stack trace in ~/.kube/shell/error.log that would be helpful.

you may also look at https://github.com/cloudnativelabs/kube-shell/blob/master/kubeshell/client.py depending on the error in the log.

@daikeren
Copy link

@murali-reddy I've inspect the stack trace in ~/.kube/shell/error.log and I found that sometimes it shows

2018-01-26 11:17:55,220 [WARNING] kubeshell.client __init__:22 - unable to load kube-config

And even the Namespace [F5] hotkey won't work.

I also try to upgrade to kuberenetes==4.0 and the message disappear and Namespace function
works correctly. But server side completion still don't work.

Here's the output of my kubectl version, I hope it may help.

Client Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.4", GitCommit:"9befc2b8928a9426501d3bf62f72849d5cbcd5a3", GitTreeState:"clean", BuildDate:"2017-11-20T05:28:34Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"7+", GitVersion:"v1.7.11-gke.1", GitCommit:"3500f53730c1fea7b57901977df165c3eb317bce", GitTreeState:"clean", BuildDate:"2017-12-08T18:05:07Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

@ohmystack
Copy link

ohmystack commented Feb 9, 2018

@murali-reddy
I found that @vogxn removed all the server side get_resource code in the commit 41b1f44 . Can we get the server side completion back?
@daikeren I found that there is no server side code in the current kube-shell version.

@murali-reddy
Copy link
Member

I will take a look over the week end and get back to you.

Please try version 0.0.21 meanwhile, it should have all the functionality.

@ptqa
Copy link

ptqa commented Apr 14, 2018

@murali-reddy any update on this?

@daikeren
Copy link

@murali-reddy Since the server side completion is an important feature for kube-shell, how about revert completer.py back to 0.21.0 first?

I think maybe we should do the refactoring of completer.py after we have some test cases for server-side completion to ensure the correctness.

@jaygorrell
Copy link

Any updates on this? Just found this project and the readme advertises server-side completion as a feature.

@dotw
Copy link

dotw commented Feb 13, 2019

the same issue here with 0.0.23, and back to 0.0.21 works

@murali-reddy
Copy link
Member

I am not having any time to look into kube-shell issues at the moment. But if there is anything i can help for someone to submit a PR I would do.

@sentatr
Copy link

sentatr commented Jun 6, 2020

Even, we are having the same issue in the mac as well. Server side completion is not working.. Please help..

@alperen-selcuk
Copy link

on mac server side not working i tried both 23 and 21 version no result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants