feat(Rewrite): @NgxSubForm() decorator is no longer needed and is not…

… exported
cloudnc · Oct 23, 2020 · a73d7e9 · a73d7e9
1 parent ba2a391
commit a73d7e9
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 30 deletions.
diff --git a/projects/ngx-sub-form/src/lib/deprecated/ngx-sub-form.component.spec.ts b/projects/ngx-sub-form/src/lib/deprecated/ngx-sub-form.component.spec.ts
@@ -453,7 +453,7 @@ describe(`NgxSubFormComponent`, () => {
       numberTwo: number;
     }
 
-    @Directive()
+    @Component({ template: '' })
     class ValidatedSubComponent extends NgxSubFormComponent<Numbered> {
       protected getFormControls() {
         return {
@@ -486,7 +486,7 @@ describe(`NgxSubFormComponent`, () => {
       passwordRepeat: string;
     }
 
-    @Directive()
+    @Component({ template: '' })
     class PasswordSubComponent extends NgxSubFormComponent<PasswordForm> {
       protected getFormControls() {
         return {

diff --git a/src/app/app.spec.e2e.ts b/src/app/app.spec.e2e.ts
@@ -61,25 +61,25 @@ context(`EJawa demo`, () => {
         DOM.list.elements.cy.eq(0).click();
         DOM.list.elements.cy.eq(1).click();
 
-        const x = hardCodedListings[1] as VehicleListing;
-        const v = x.product as Speeder;
+        const vehicle = hardCodedListings[1] as VehicleListing;
+        const speeder = vehicle.product as Speeder;
 
         const expectedObj: FormElement = {
-          title: x.title,
-          price: '£' + x.price.toLocaleString(),
+          title: vehicle.title,
+          price: '£' + vehicle.price.toLocaleString(),
           inputs: {
-            id: x.id,
-            title: x.title,
-            imageUrl: x.imageUrl,
-            price: x.price + '',
-            listingType: x.listingType,
+            id: vehicle.id,
+            title: vehicle.title,
+            imageUrl: vehicle.imageUrl,
+            price: vehicle.price + '',
+            listingType: vehicle.listingType,
             vehicleForm: {
-              vehicleType: x.product.vehicleType,
+              vehicleType: vehicle.product.vehicleType,
               speederForm: {
-                color: v.color,
-                canFire: v.canFire,
-                crewMembers: v.crewMembers,
-                maximumSpeed: v.maximumSpeed,
+                color: speeder.color,
+                canFire: speeder.canFire,
+                crewMembers: speeder.crewMembers,
+                maximumSpeed: speeder.maximumSpeed,
               },
             },
           },
@@ -95,25 +95,25 @@ context(`EJawa demo`, () => {
         DOM.list.elements.cy.eq(1).click();
         DOM.list.elements.cy.eq(0).click();
 
-        const x = hardCodedListings[0] as VehicleListing;
-        const s = x.product as Spaceship;
+        const vehicle = hardCodedListings[0] as VehicleListing;
+        const spaceship = vehicle.product as Spaceship;
 
         const expectedObj: FormElement = {
-          title: x.title,
-          price: '£' + x.price.toLocaleString(),
+          title: vehicle.title,
+          price: '£' + vehicle.price.toLocaleString(),
           inputs: {
-            id: x.id,
-            title: x.title,
-            imageUrl: x.imageUrl,
-            price: x.price + '',
-            listingType: x.listingType,
+            id: vehicle.id,
+            title: vehicle.title,
+            imageUrl: vehicle.imageUrl,
+            price: vehicle.price + '',
+            listingType: vehicle.listingType,
             vehicleForm: {
-              vehicleType: x.product.vehicleType,
+              vehicleType: vehicle.product.vehicleType,
               spaceshipForm: {
-                color: s.color,
-                canFire: s.canFire,
-                crewMembers: s.crewMembers,
-                wingCount: s.wingCount,
+                color: spaceship.color,
+                canFire: spaceship.canFire,
+                crewMembers: spaceship.crewMembers,
+                wingCount: spaceship.wingCount,
               },
             },
           },