Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SQLite database #10

Merged
merged 3 commits into from Jul 27, 2023
Merged

Conversation

zefir-git
Copy link
Member

This PR makes it possible to choose between using SQLite or MariaDB for the database.

SQLite

SQLite stores all data locally in a file (by default bank.db, this is configurable). The advantage is that you do not need to set-up an external database server and manage authentication. If you wish to migrate the BankAccounts data from one server to another, you can simply copy this file to your new server.

This is the default option and works out of the box without having to set-up anything.

MariaDB

Using the MariaDB option allows you to connect to a remote MariaDB server. If you want to sync banking data between two servers using this plugin, you can use the same database on both servers. If you are developing a website or another plugin, you can also easily directly read all BankAccounts data from the MariaDB database.

To use this option you must set-up a MariaDB server, create a database and a user that is granted full privileges to the database.

@zefir-git zefir-git added the feature New features label Jul 27, 2023
@zefir-git zefir-git self-assigned this Jul 27, 2023
@zefir-git zefir-git linked an issue Jul 27, 2023 that may be closed by this pull request
@zefir-git zefir-git marked this pull request as ready for review July 27, 2023 20:31
Copy link
Member

@km127pl km127pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine to me, shading the entire org.xerial/sqlite-jdbc is a bit too much but you can't do much about it except using libraries/org/xerial/sqlite-jdbc in the server root, but it's unclear if it's always present there.
On git-Paper-22 the directory libraries/org/xerial/sqlite-jdbc/3.42.0.0/sqlite-jdbc-3.42.0.0.jar exists on first clean server startup

@zefir-git
Copy link
Member Author

All looks fine to me, shading the entire org.xerial/sqlite-jdbc is a bit too much but you can't do much about it except using libraries/org/xerial/sqlite-jdbc in the server root, but it's unclear if it's always present there. On git-Paper-22 the directory libraries/org/xerial/sqlite-jdbc/3.42.0.0/sqlite-jdbc-3.42.0.0.jar exists on first clean server startup

Thank you for the suggestion. I have opened #12.

@zefir-git zefir-git merged commit 5edd091 into master Jul 27, 2023
2 checks passed
@zefir-git zefir-git deleted the 8-no-hooked-integration branch July 27, 2023 22:00
@zefir-git zefir-git mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

No hooked integration?
2 participants