Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort POS items checksum arrays before comparing #104

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

zefir-git
Copy link
Member

Purchasing items from a POS may fail with "Items in POS have changed" error if for some reason the order of the items does not match the order of the validation checksums.

This PR fixes that issue by sorting both arrays before comparing.

@zefir-git zefir-git added the bug Something isn't working label Feb 28, 2024
@zefir-git zefir-git self-assigned this Feb 28, 2024
Copy link
Member

@Dviih Dviih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me.

@zefir-git zefir-git merged commit 93ea9fd into master Feb 28, 2024
1 check passed
@zefir-git zefir-git deleted the fix-pos-checksum-validation branch February 28, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants