Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce maven central mirror parameter #192

Merged
merged 2 commits into from
May 27, 2024

Conversation

yannickchristhomas
Copy link
Contributor

No description provided.

Copy link
Member

@schnatterer schnatterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After working through my comments please rebase on main.

After starting the GOP, both petclinic-plain and petclinic-helm failed with this:

java.io.FileNotFoundException: The specified user settings file does not exist: /tmp/gitops-playground-jenkins-agent/workspace/xample-apps_petclinic-plain_main/.m2/settings.xml

After restarting the jobs, they succeeded. Did those work fine for you?

Please also do a negative test: When --maven-central-mirror is not set, we don't want a an empty env var here
http://jenkins.localhost/manage/configure

image

For the record, this is how I tested

 docker run --rm -t  -u $(id -u)  \
  -v ~/.config/k3d/kubeconfig-gitops-playground.yaml:/home/.kube/config \
    --net=host \
      gitops-playground:dev --yes -x --argocd --base-url=http://localhost --ingress-nginx  --maven-central-mirror https://maven-central.storage.googleapis.com/maven2/ 

Copy link
Member

@schnatterer schnatterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there 👍 🙂
Maybe I confused you with the comment about the test. If so, lets talk about it.

@schnatterer schnatterer merged commit a3f0ab5 into main May 27, 2024
1 check passed
@schnatterer schnatterer deleted the feature/maven-mirror-parameter branch May 27, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants