-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce maven central mirror parameter #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After working through my comments please rebase on main.
After starting the GOP, both petclinic-plain
and petclinic-helm
failed with this:
java.io.FileNotFoundException: The specified user settings file does not exist: /tmp/gitops-playground-jenkins-agent/workspace/xample-apps_petclinic-plain_main/.m2/settings.xml
After restarting the jobs, they succeeded. Did those work fine for you?
Please also do a negative test: When --maven-central-mirror
is not set, we don't want a an empty env var here
http://jenkins.localhost/manage/configure
For the record, this is how I tested
docker run --rm -t -u $(id -u) \
-v ~/.config/k3d/kubeconfig-gitops-playground.yaml:/home/.kube/config \
--net=host \
gitops-playground:dev --yes -x --argocd --base-url=http://localhost --ingress-nginx --maven-central-mirror https://maven-central.storage.googleapis.com/maven2/
src/main/groovy/com/cloudogu/gitops/config/ApplicationConfigurator.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/com/cloudogu/gitops/cli/GitopsPlaygroundCli.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/com/cloudogu/gitops/features/argocd/ArgoCD.groovy
Outdated
Show resolved
Hide resolved
9ec30ff
to
32b21d6
Compare
32b21d6
to
45a29dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there 👍 🙂
Maybe I confused you with the comment about the test. If so, lets talk about it.
No description provided.