Fix waiting for node on startup #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schnatterer
force-pushed
the
feature/wait-for-node
branch
from
640e363
to
d23d35d
Compare
The method name claimed something the method did not do: waiting. Before d2f218c / #174 we had a bash method of the same name that actually waited. It was called before the Groovy code was called. So all those years K8sClient.waitForNode() lied about its implementation, but it was no problem. After the bash implementation was gone, however, our build started to become flaky with these kinds of errors: TRACE c.c.gitops.utils.CommandExecutor - Executing command: '[kubectl, get, node, -oname]' TRACE c.c.gitops.utils.CommandExecutor - Executing command: '[head, -n1]' TRACE c.c.gitops.utils.CommandExecutor - Executing command: '[kubectl, get, , --template='{{range .status.addresses}}{{ if eq .type "InternalIP" }}{{.address}}{{break}}{{end}}{{end}}']' 11:34:12 error: the server doesn't have a resource type "" The problem likely being that the k3d cluster wasn't ready, yet and returned empty on 'get node' without waiting. The empty returned was then passed to the following function which then failed. This should no be fixed.
schnatterer
force-pushed
the
feature/wait-for-node
branch
from
d23d35d
to
d6de6b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K8sClient.waitForNode(): The method name claimed something the method did not do - waiting.
Before d2f218c / #174 we had a bash method of the same name that actually waited.
It was called before the Groovy code was called.
So all those years
K8sClient.waitForNode()lied about its implementation, but it was no problem.After the bash implementation was gone, however, our build started to become flaky with these kinds of errors:
The problem likely being that the k3d cluster wasn't ready, yet and returned empty on
get node'without waiting.The empty returned was then passed to the following function which then failed.
This should no be fixed.